From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3836 invoked by alias); 18 Jan 2010 04:16:18 -0000 Received: (qmail 3825 invoked by uid 22791); 18 Jan 2010 04:16:17 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 18 Jan 2010 04:16:13 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 328392BAB96; Sun, 17 Jan 2010 23:16:12 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id c0NuvzRfFv9t; Sun, 17 Jan 2010 23:16:12 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 099D62BAB86; Sun, 17 Jan 2010 23:16:10 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id BA076F5970; Mon, 18 Jan 2010 08:15:57 +0400 (RET) Date: Mon, 18 Jan 2010 04:16:00 -0000 From: Joel Brobecker To: Luis Machado Cc: Thiago Jung Bauermann , gdb-patches@sourceware.org, Matt Tyrlik Subject: Re: [PATCH 1/4] Support the new BookE ptrace interface Message-ID: <20100118041557.GD17397@adacore.com> References: <200912232230.56227.bauerman@br.ibm.com> <200912311518.14325.bauerman@br.ibm.com> <20100105045130.GA24777@adacore.com> <1263611335.2967.6.camel@gargoyle> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1263611335.2967.6.camel@gargoyle> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-01/txt/msg00440.txt.bz2 > 2010-01-16 Sergio Durigan Junior > Thiago Jung Bauermann > > * ppc-linux-nat.c (PTRACE_GET_DEBUGREG): Update comment. > (PPC_PTRACE_GETWDBGINFO, PPC_PTRACE_SETHWDEBUG, PPC_PTRACE_DELHWDEBUG, > ppc_debug_info, PPC_DEBUG_FEATURE_INSN_BP_RANGE, > PPC_DEBUG_FEATURE_INSN_BP_MASK, PPC_DEBUG_FEATURE_DATA_BP_RANGE, > PPC_DEBUG_FEATURE_DATA_BP_MASK, ppc_hw_breakpoint, > PPC_BREAKPOINT_TRIGGER_EXECUTE, PPC_BREAKPOINT_TRIGGER READ, > PPC_BREAKPOINT_TRIGGER_WRITE, PPC_BREAKPOINT_TRIGGER_RW, > PPC_BREAKPOINT_MODE_EXACT PPC_BREAKPOINT_MODE_RANGE_INCLUSIVE, > PPC_BREAKPOINT_MODE_RANGE_EXCLUSIVE, PPC_BREAKPOINT_MODE_MASK, > PPC_BREAKPOINT_CONDITION_NONE, PPC_BREAKPOINT_CONDITION_AND, > PPC_BREAKPOINT_CONDITION_EXACT, PPC_BREAKPOINT_CONDITION_OR, > PPC_BREAKPOINT_CONDITION_AND_OR, PPC_BREAKPOINT_CONDITION_BE_ALL, > PPC_BREAKPOINT_CONDITION_BE_SHIFT, PPC_BREAKPOINT_CONDITION_BE): > Define, in case doesn't provide it. > (have_ptrace_new_debug_booke): New global. > (ppc_linux_check_watch_resources): Renamed to ... > (ppc_linux_can_use_hw_breakpoint): ... this. Handle BookE processors. > (booke_debug_info): New variable. > (max_slots_number): Ditto. > (hw_break_tuple): New struct. > (thread_points): Ditto. > (ppc_threads): New variable. > (PPC_DEBUG_CURRENT_VERSION): New define. > (ppc_linux_region_ok_for_hw_watchpoint): Handle BookE processors. > (booke_cmp_hw_point): New function. > (booke_find_thread_points_by_tid): Ditto. > (booke_insert_point): Ditto. > (booke_remove_point): Ditto. > (ppc_linux_insert_hw_breakpoint): Ditto. > (ppc_linux_remove_hw_breakpoint): Ditto. > (ppc_linux_insert_watchpoint): Handle BookE processors. > (ppc_linux_remove_watchpoint): Ditto. > (ppc_linux_new_thread): Ditto. > (ppc_linux_stopped_data_address): Ditto. > (ppc_linux_watchpoint_addr_within_range): Ditto. > (ppc_linux_read_description): Query the target to know if it > supports the new kernel BookE interface. > (_initialize_ppc_linux_nat): Initialize to_insert_hw_breakpoint and > to_remove_hw_breakpoint fields of the target operations struct. Approved :). Now the *real* fun can begin, right? (designing the support for h/w accelerated watchpoint conditions) ;-) -- Joel