From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4972 invoked by alias); 14 Jan 2010 21:22:58 -0000 Received: (qmail 4964 invoked by uid 22791); 14 Jan 2010 21:22:57 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 14 Jan 2010 21:22:51 +0000 Received: from int-mx05.intmail.prod.int.phx2.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.18]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o0ELMovl016710 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 14 Jan 2010 16:22:50 -0500 Received: from host0.dyn.jankratochvil.net (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx05.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o0ELMl04008226 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 14 Jan 2010 16:22:49 -0500 Received: from host0.dyn.jankratochvil.net (localhost [127.0.0.1]) by host0.dyn.jankratochvil.net (8.14.3/8.14.3) with ESMTP id o0ELMlj2020535; Thu, 14 Jan 2010 22:22:47 +0100 Received: (from jkratoch@localhost) by host0.dyn.jankratochvil.net (8.14.3/8.14.3/Submit) id o0ELMkxh020534; Thu, 14 Jan 2010 22:22:46 +0100 Date: Thu, 14 Jan 2010 21:22:00 -0000 From: Jan Kratochvil To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [patch 15/15] PIE: Drop PIE "GDB does NOT currently support" Message-ID: <20100114212246.GH18716@host0.dyn.jankratochvil.net> References: <20091109210136.GP19138@host0.dyn.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-08-17) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-01/txt/msg00390.txt.bz2 On Mon, 09 Nov 2009 22:53:43 +0100, Tom Tromey wrote: > >>>>> "Jan" == Jan Kratochvil writes: > > Jan> gdb/ > Jan> * linux-tdep.c: Remove includes gdbcore.h, observer.h and elf-bfd.h. > Jan> (check_is_pie_binary, _initialize_linux_tdep): Remove. > Jan> gdb/testsuite/ > Jan> * gdb.base/pie-support.exp, gdb.base/pie-support.c: Remove. > > This is ok once the rest of the series is approved. Checked-in. + * gdb.base/pie-support.exp, gdb.base/pie-support.c: Remove. These files were really removed but cvsweb has some bug so the removal is not present in the attachment below. http://sourceware.org/ml/gdb-cvs/2010-01/msg00127.html -> http://sources.redhat.com/cgi-bin/cvsweb.cgi/src/gdb/testsuite/gdb.base/Attic/pie-support.c.diff Error: src/gdb/testsuite/gdb.base/Attic/pie-support.c.diff: no such file or directory http://sources.redhat.com/cgi-bin/cvsweb.cgi/src/gdb/testsuite/gdb.base/Attic/pie-support.exp.diff Error: src/gdb/testsuite/gdb.base/Attic/pie-support.exp.diff: no such file or directory Thanks, Jan http://sourceware.org/ml/gdb-cvs/2010-01/msg00127.html --- src/gdb/ChangeLog 2010/01/14 21:16:51 1.11251 +++ src/gdb/ChangeLog 2010/01/14 21:20:09 1.11252 @@ -1,5 +1,10 @@ 2010-01-14 Jan Kratochvil + * linux-tdep.c: Remove includes gdbcore.h, observer.h and elf-bfd.h. + (check_is_pie_binary, _initialize_linux_tdep): Remove. + +2010-01-14 Jan Kratochvil + * solib-svr4.c (svr4_exec_displacement): New comment for entry_point. Replace exec_entry_point call by bfd_get_start_address. --- src/gdb/linux-tdep.c 2010/01/01 07:31:37 1.6 +++ src/gdb/linux-tdep.c 2010/01/14 21:20:11 1.7 @@ -18,13 +18,10 @@ along with this program. If not, see . */ #include "defs.h" -#include "gdbcore.h" #include "gdbtypes.h" #include "linux-tdep.h" -#include "observer.h" #include "auxv.h" #include "target.h" -#include "elf-bfd.h" #include "elf/common.h" /* This function is suitable for architectures that don't @@ -155,33 +152,3 @@ return target_is_uclinux; } - -/* Observer for the executable_changed event, to check whether the new - exec binary is a PIE (Position Independent Executable) specimen, which - is currently unsupported. */ - -static void -check_is_pie_binary (void) -{ - Elf_Internal_Ehdr *elf_hdr; - - if (!exec_bfd) - return; - else if (bfd_get_flavour (exec_bfd) != bfd_target_elf_flavour) - return; - - if (elf_tdata (exec_bfd)->elf_header->e_type == ET_DYN) - warning (_("\ -The current binary is a PIE (Position Independent Executable), which\n\ -GDB does NOT currently support. Most debugger features will fail if used\n\ -in this session.\n")); -} - -/* Provide a prototype to silence -Wmissing-prototypes. */ -extern initialize_file_ftype _initialize_linux_tdep; - -void -_initialize_linux_tdep (void) -{ - observer_attach_executable_changed (check_is_pie_binary); -} --- src/gdb/testsuite/ChangeLog 2010/01/14 21:15:00 1.2088 +++ src/gdb/testsuite/ChangeLog 2010/01/14 21:20:12 1.2089 @@ -1,5 +1,9 @@ 2010-01-14 Jan Kratochvil + * gdb.base/pie-support.exp, gdb.base/pie-support.c: Remove. + +2010-01-14 Jan Kratochvil + * gdb.base/valgrind-db-attach.exp, gdb.base/valgrind-db-attach.c: New. 2010-01-14 Jan Kratochvil