Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Pedro Alves <pedro@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA/commit] Rename to_can_use_hw_breakpoint ->  to_can_use_hw_watchpoint.
Date: Wed, 13 Jan 2010 15:02:00 -0000	[thread overview]
Message-ID: <20100113150201.GR2007@adacore.com> (raw)
In-Reply-To: <201001131407.04501.pedro@codesourcery.com>

> That's not actually true.
[...]

Thanks for the feedback. Sigh: I guess the first thing is to improve
the documentation of this routine...

I would also love to clarify the "other_type" argument. It's just
not obvious what this is about...

> > In fact, the macro wrapping the call to this routine in current_target 
> > is actually named target_can_use_hardware_watchpoint.  This patch renames 
> > this routine in the target_ops vector, as well as all
> > target-specific implementations, to keep things consistent. 
> 
> Yeah.  No real objections from me.  Consistency is good.

Sounds like renaming to use "watchpoint" wouldn't make things any
better, though.  I'm trying to be lazy, as I don't have the resources
right now to start overhauling the h/w watchpoint & breakpoint support.
But I don't know if there is anything that's going to help short of
that.  Perhaps a quick renaming to use "point" instead of "breakpoint"
would make things slightly clearer.

-- 
Joel


      reply	other threads:[~2010-01-13 15:02 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-13 10:54 Joel Brobecker
2010-01-13 14:07 ` Pedro Alves
2010-01-13 15:02   ` Joel Brobecker [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100113150201.GR2007@adacore.com \
    --to=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=pedro@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox