From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13183 invoked by alias); 11 Jan 2010 16:08:09 -0000 Received: (qmail 13165 invoked by uid 22791); 11 Jan 2010 16:08:08 -0000 X-SWARE-Spam-Status: No, hits=-1.4 required=5.0 tests=AWL,BAYES_00,FAKE_REPLY_C,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 11 Jan 2010 16:08:04 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o0BG7WK1012222 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 11 Jan 2010 11:07:33 -0500 Received: from host0.dyn.jankratochvil.net (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o0BG7O4u025116 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 11 Jan 2010 11:07:31 -0500 Received: from host0.dyn.jankratochvil.net (localhost [127.0.0.1]) by host0.dyn.jankratochvil.net (8.14.3/8.14.3) with ESMTP id o0BG7NsL013473; Mon, 11 Jan 2010 17:07:23 +0100 Received: (from jkratoch@localhost) by host0.dyn.jankratochvil.net (8.14.3/8.14.3/Submit) id o0BG7KVQ013470; Mon, 11 Jan 2010 17:07:20 +0100 Date: Mon, 11 Jan 2010 16:08:00 -0000 From: Jan Kratochvil To: Tristan Gingold , Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [patch] Fix false warning: Shared library is missing debugging information. Message-ID: <20100111160720.GB12356@host0.dyn.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201001111523.46705.pedro@codesourcery.com> <006D59C6-DF98-4113-96E2-3F6374528EF3@adacore.com> User-Agent: Mutt/1.5.20 (2009-08-17) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-01/txt/msg00254.txt.bz2 On Mon, 11 Jan 2010 16:22:06 +0100, Tristan Gingold wrote: > I think you should use !objfile_has_symbols (so->objfile) instead. OK, missed that function, thanks. > It is somewhat wrong to check objfile->separate_debug_objfile without > checking the whole chain, because the chain has no particular order. When thinking more about it it is probably more important than I thought. One can have one of the .o files stripped while not the other ones. On Mon, 11 Jan 2010 16:23:46 +0100, Pedro Alves wrote: > separate_debug_objfile is now a list, so shouldn't you now look > over them all (main and all seperate objfiles) for symbols? yes... No regressions on {x86_64,x86_64-m32,i686}-fedora12-linux-gnu. Thanks, Jan 2010-01-11 Jan Kratochvil Tristan Gingold * solib.c (info_sharedlibrary_command): Replace objfile_has_partial_symbols and objfile_has_full_symbols calls by objfile_has_symbols. --- a/gdb/solib.c +++ b/gdb/solib.c @@ -863,8 +863,7 @@ info_sharedlibrary_command (char *pattern, int from_tty) if (! ui_out_is_mi_like_p (interp_ui_out (top_level_interpreter ())) && so->symbols_loaded - && !objfile_has_partial_symbols (so->objfile) - && !objfile_has_full_symbols (so->objfile)) + && !objfile_has_symbols (so->objfile)) { so_missing_debug_info = 1; ui_out_field_string (uiout, "syms-read", "Yes (*)");