Re: D language support

Tom Tromey
2010-04-20T21:39:49Z

>>>>> "Mihail" == Mihail Zenkov <mihail.zenkov@gmail.com> writes:

Mihail> Sorry for too very long delay. I fix patch as you and Joel
Mihail> suggested, i hope it ready for inclusion.

It is very close. In fact, I think I only saw formatting nits.
Thanks for working on this.

I think this needs a NEWS entry.

Mihail> gdb/ChangeLog:
[...]
Mihail> * doc/gdb.texinfo: Add mention about D language support.
[...]
Mihail> * testsuite/gdb.base/default.exp: Fix "set language" test.

These directories have their own ChangeLog files, so you have to split
up the entry.

Mihail> +extern void c_emit_char (int c, struct type *type, struct ui_file *stream, int quoter);

This wraps past 80 columns, so it should be split after the second comma.

Mihail> +static const char* mangled_str;

GDB style is "const char *mangled_str" -- the "*" is in the wrong place.

Mihail> + obstack_blank(&tempbuf, -1);

Space before open paren.

Mihail> + } else if (strncmp (mangled_str, "__Class_", 8) == 0)

Newline before "else".

Mihail> +extern int d_val_print (struct type *type, const gdb_byte *valaddr,
Mihail> + int embedded_offset, CORE_ADDR address,
Mihail> + struct ui_file *stream, int recurse,
Mihail> + const struct value_print_options *options);
Mihail> +#endif /* !defined (D_LANG_H) */

Blank line before the #endif.

thanks,
Tom