From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-69332-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 28015 invoked by alias); 8 Jan 2010 07:38:21 -0000
Received: (qmail 28005 invoked by uid 22791); 8 Jan 2010 07:38:20 -0000
X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 	tests=AWL,BAYES_00
X-Spam-Check-By: sourceware.org
Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 08 Jan 2010 07:38:16 +0000
Received: from localhost (localhost.localdomain [127.0.0.1]) 	by filtered-rock.gnat.com (Postfix) with ESMTP id 39BA22BAB2B; 	Fri,  8 Jan 2010 02:38:15 -0500 (EST)
Received: from rock.gnat.com ([127.0.0.1]) 	by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) 	with LMTP id rky3-Jc-TZAx; Fri,  8 Jan 2010 02:38:15 -0500 (EST)
Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) 	by rock.gnat.com (Postfix) with ESMTP id B36362BAB3D; 	Fri,  8 Jan 2010 02:38:14 -0500 (EST)
Received: by joel.gnat.com (Postfix, from userid 1000) 	id 5CFBFF595E; Fri,  8 Jan 2010 11:38:06 +0400 (RET)
Date: Fri, 08 Jan 2010 07:38:00 -0000
From: Joel Brobecker <brobecker@adacore.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] Fix crash reading broken stabs
Message-ID: <20100108073806.GB29312@adacore.com>
References: <20100107175054.GA15215@host0.dyn.jankratochvil.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20100107175054.GA15215@host0.dyn.jankratochvil.net>
User-Agent: Mutt/1.5.20 (2009-06-14)
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-01/txt/msg00156.txt.bz2

> gdb/
> 2010-01-07  Jan Kratochvil  <jan.kratochvil@redhat.com>
> 
> 	* stabsread.c (read_args): Handle zero arguments.

> gdb/testsuite/
> 2010-01-07  Jan Kratochvil  <jan.kratochvil@redhat.com>
> 
> 	* gdb.stabs/weird.def (args93): New.

Both OK. If you don't mind, could you add just a tiny bit of
information in the comment you added in weird.def? Something
like:

# See read_args "Invalid (empty) method arguments" error
# (there is an unexpected semi-colon after =@s8;-16 that
# used to cause a GDB crash).

Thank you,
-- 
Joel