From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3233 invoked by alias); 5 Jan 2010 04:51:52 -0000 Received: (qmail 3218 invoked by uid 22791); 5 Jan 2010 04:51:49 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 05 Jan 2010 04:51:45 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 394CF2BAB85; Mon, 4 Jan 2010 23:51:43 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id tYLSoByoj-LM; Mon, 4 Jan 2010 23:51:43 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 7E7422BAB32; Mon, 4 Jan 2010 23:51:41 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id D29F4F5936; Tue, 5 Jan 2010 05:51:30 +0100 (CET) Date: Tue, 05 Jan 2010 04:51:00 -0000 From: Joel Brobecker To: Thiago Jung Bauermann Cc: gdb-patches@sourceware.org, Luis Machado , Matt Tyrlik Subject: Re: [PATCH 1/4] Support the new BookE ptrace interface Message-ID: <20100105045130.GA24777@adacore.com> References: <200912232230.56227.bauerman@br.ibm.com> <200912311518.14325.bauerman@br.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200912311518.14325.bauerman@br.ibm.com> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-01/txt/msg00071.txt.bz2 > 2009-12-31 Sergio Durigan Junior > Thiago Jung Bauermann > > * ppc-linux-nat.c (PTRACE_GET_DEBUGREG): Update comment. > (PPC_PTRACE_GETWDBGINFO, PPC_PTRACE_SETHWDEBUG, PPC_PTRACE_DELHWDEBUG, > ppc_debug_info, PPC_DEBUG_FEATURE_INSN_BP_RANGE, > PPC_DEBUG_FEATURE_INSN_BP_MASK, PPC_DEBUG_FEATURE_DATA_BP_RANGE, > PPC_DEBUG_FEATURE_DATA_BP_MASK, ppc_hw_breakpoint, > PPC_BREAKPOINT_TRIGGER_EXECUTE, PPC_BREAKPOINT_TRIGGER READ, > PPC_BREAKPOINT_TRIGGER_WRITE, PPC_BREAKPOINT_TRIGGER_RW, > PPC_BREAKPOINT_MODE_EXACT PPC_BREAKPOINT_MODE_RANGE_INCLUSIVE, > PPC_BREAKPOINT_MODE_RANGE_EXCLUSIVE, PPC_BREAKPOINT_MODE_MASK, > PPC_BREAKPOINT_CONDITION_NONE, PPC_BREAKPOINT_CONDITION_AND, > PPC_BREAKPOINT_CONDITION_EXACT, PPC_BREAKPOINT_CONDITION_OR, > PPC_BREAKPOINT_CONDITION_AND_OR, PPC_BREAKPOINT_CONDITION_BE_ALL, > PPC_BREAKPOINT_CONDITION_BE_SHIFT, PPC_BREAKPOINT_CONDITION_BE): > Define, in case doesn't provide it. > (have_ptrace_new_debug_booke): New global. > (ppc_linux_check_watch_resources): Renamed to ... > (ppc_linux_can_use_hw_breakpoint): ... this. Handle BookE processors. > (booke_debug_info): New variable. > (max_slots_number): Ditto. > (hw_break_tuple): New struct. > (thread_points): Ditto. > (ppc_threads): New variable. > (PPC_DEBUG_CURRENT_VERSION): New define. > (ppc_linux_region_ok_for_hw_watchpoint): Handle BookE processors. > (booke_cmp_hw_point): New function. > (booke_find_thread_points_by_tid): Ditto. > (booke_insert_point): Ditto. > (booke_remove_point): Ditto. > (ppc_linux_insert_hw_breakpoint): Ditto. > (ppc_linux_remove_hw_breakpoint): Ditto. > (ppc_linux_insert_watchpoint): Handle BookE processors. > (ppc_linux_remove_watchpoint): Ditto. > (ppc_linux_new_thread): Ditto. > (ppc_linux_stopped_data_address): Ditto. > (ppc_linux_watchpoint_addr_within_range): Ditto. > (ppc_linux_read_description): Query the target to know if it > supports the new kernel BookE interface. > (_initialize_ppc_linux_nat): Initialize to_insert_hw_breakpoint and > to_remove_hw_breakpoint fields of the target operations struct. Still looks good to me :). Just a couple of nits, but otherwise approved. It would still be nice if Ulrich had a chance to take a quick look ;-). > +struct ppc_debug_info { > + uint32_t version; /* Only version 1 exists to date */ The curly brace should be at the beginning of the next line. And the indentation (probably a copy-paste from the kernel headers?) needs to be adjusted. Not that it really matters a whole lot. For this section, if it makes things simpler to preserve the indentation of the original, I could be convinced to leave the code untouched. > +static int get_trigger_type (int rw) Formatting nit as well: static int get_trigger_type (int rw) -- Joel