From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17989 invoked by alias); 4 Jan 2010 15:07:13 -0000 Received: (qmail 17977 invoked by uid 22791); 4 Jan 2010 15:07:12 -0000 X-SWARE-Spam-Status: No, hits=-1.3 required=5.0 tests=AWL,BAYES_00,MSGID_FROM_MTA_HEADER,SPF_SOFTFAIL X-Spam-Check-By: sourceware.org Received: from mtagate6.de.ibm.com (HELO mtagate6.de.ibm.com) (195.212.17.166) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 04 Jan 2010 15:07:08 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate6.de.ibm.com (8.13.1/8.13.1) with ESMTP id o04F7565026366 for ; Mon, 4 Jan 2010 15:07:05 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id o04F74061097794 for ; Mon, 4 Jan 2010 16:07:04 +0100 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id o04F744n013346 for ; Mon, 4 Jan 2010 16:07:04 +0100 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with SMTP id o04F735j013316; Mon, 4 Jan 2010 16:07:03 +0100 Message-Id: <201001041507.o04F735j013316@d12av02.megacenter.de.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Mon, 04 Jan 2010 16:07:03 +0100 Subject: Re: [rfc] Handle DWARF-2 value pieces residing in *parts* of a register To: tromey@redhat.com Date: Mon, 04 Jan 2010 15:07:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org In-Reply-To: from "Tom Tromey" at Dec 21, 2009 01:36:29 PM MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-01/txt/msg00057.txt.bz2 Tom Tromey wrote: > >>>>> "Ulrich" == Ulrich Weigand writes: > > Ulrich> Now, according to the DWARF-2 standard, the location of register pieces > Ulrich> of smaller than full register size is defined by the platform ABI. > Ulrich> For the placement of a small value in a *single* register we have a > Ulrich> gdbarch callback (gdbarch_value_from_register); maybe we need something > Ulrich> like that for value pieces as well. At the very least, we ought to > Ulrich> you the same default as default_value_from_register does: assume > Ulrich> partial register use implies the least-significant part of the register. > > Ulrich> The patch below implements this. > > I think this seems reasonable. > > It seems straightforward enough to add an arch method if we ever > actually need one. I wouldn't worry about it unless we already know of > such a machine. Thanks for the review. I've checked the patch in now. > Ulrich> a register, assume the least-signficant part is used. > > Typo, "significant". Fixed, thanks! Bye, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com