From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23497 invoked by alias); 2 Jan 2010 09:33:45 -0000 Received: (qmail 23489 invoked by uid 22791); 2 Jan 2010 09:33:44 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 02 Jan 2010 09:33:39 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id C575F2BAB95; Sat, 2 Jan 2010 04:33:37 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id OZcl4cxEvV28; Sat, 2 Jan 2010 04:33:37 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 30BF72BAB90; Sat, 2 Jan 2010 04:33:37 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 57EDFF5937; Sat, 2 Jan 2010 10:33:02 +0100 (CET) Date: Sat, 02 Jan 2010 09:33:00 -0000 From: Joel Brobecker To: Michael Cc: gdb-patches@sourceware.org Subject: Re: gdb-patch mailing list Message-ID: <20100102093302.GA12123@adacore.com> References: <4B3E4DC6.7020901@cyberfiber.org> <20100102043704.GR548@adacore.com> <4B3F03C4.1040104@cyberfiber.org> <4B3F083C.2080300@cyberfiber.org> <20100102093213.GX2788@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100102093213.GX2788@adacore.com> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-01/txt/msg00025.txt.bz2 [I removed gdb-patches by accident - resending] > >>>- Add new tracepoint action teval. > >>>- * tracepoint.c (teval_pseudocommand): New function. > >>>- (validate_actionline): Add teval action case. > >>>- (encode_actions): Ditto. > >>>- (_initialize_tracepoint): Define teval pseudocommand. > >>>- * NEWS: Mention teval. > >>[...] > >> > >>The leading minus '-' signs mean that you propose to remove this entry > >>(and many other entries). I don't think you really meant that. > this is not mine, I think you are in error?? This is exactly what I am saying: The patch you sent, if applied, would cause all these entries in the ChangeLog file to be removed (once approved, we apply use "patch" to apply the patch automatically, we do not re-do the changes manually). We both agree that this is not intentional. This is why you have to double-check the contents of your patch before you send it, to make sure that it contains all the changes that are you are proposing to make, but also *only* the changes that you are proposing to make. It will probably simplify your life to just start over. Checkout the sources from scratch, make your changes manually, and then extract the diff. If you used CVS, then: % cvs diff -up FILE1 FILE2 FILE3 [etc...] > patch.diff If you used git: % git diff > patch.diff But regardless, always make sure to double-check your patch before sending it. You may have slipped some unintentional changes by accident, you never know. -- Joel