From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1602 invoked by alias); 1 Jan 2010 08:19:18 -0000 Received: (qmail 1592 invoked by uid 22791); 1 Jan 2010 08:19:17 -0000 X-SWARE-Spam-Status: No, hits=-0.9 required=5.0 tests=AWL,BAYES_00,FH_DATE_PAST_20XX X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 01 Jan 2010 08:19:12 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 0C26E2BABAA; Fri, 1 Jan 2010 03:19:10 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id lFl18VgV3Ige; Fri, 1 Jan 2010 03:19:10 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 6C4BF2BABA4; Fri, 1 Jan 2010 03:19:10 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 6F990F5937; Fri, 1 Jan 2010 09:18:39 +0100 (CET) Date: Fri, 01 Jan 2010 08:19:00 -0000 From: Joel Brobecker To: Michael Cc: gdb-patches@sourceware.org Subject: Re: patch for testing purposes Message-ID: <20100101081839.GQ2788@adacore.com> References: <4B3B07F6.1020604@cyberfiber.org> <20091230081342.GD2788@adacore.com> <4B3B3AB1.5060106@cyberfiber.org> <20091230114518.GD548@adacore.com> <4B3C8D28.9070109@cyberfiber.org> <20091231115033.GL2788@adacore.com> <4B3D20F7.6010203@cyberfiber.org> <20100101033536.GM2788@adacore.com> <4B3DA076.8090508@cyberfiber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4B3DA076.8090508@cyberfiber.org> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-01/txt/msg00006.txt.bz2 > Here it is again. For your information, I added a few lines of code > to the 'info float' statement. Hope you like them :) You are going to hate me, but it's still not right. Sorry! How are you generating your diff? From the markers in the diff patch, it looks like you generated it without the assistance of a version-control system. You are making things harder for you because you have to make sure that the tree that you use as a reference matches exactly what you started from. Otherwise, you end up with differences that should not be in the patch, as you are seeing at least in your patch to the ChangeLog file. I strongly recommend that you start the safest way: Checkout the sources from either CVS or git, apply your changes to these sources, and then use either CVS or git to generate the diff (either "cvs diff -up" or "git diff"). I would both sending a diff to the ChangeLog file but simply put the ChangeLog entry in the email body. You can have a look at previous messages sent to this mailing-list as a guideline. Please verify that the patch you are sending corresponds exactly to the changes you made, no more, no less. Please also make sure to say that you did change your test by running the testsuite before and after your change, comparing the results, and on which platform. I can help walking you through this process if you need help. But first, let's make sure you know how to generate the patch properly, and that you know how to present them to this mailing-list. I hope you're not feeling discouraged. This is only a matter of learning the procedure, and once you know it, you won't have to go through this again, for most if not all GNU projects. -- Joel