From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9548 invoked by alias); 1 Jan 2010 03:57:16 -0000 Received: (qmail 9539 invoked by uid 22791); 1 Jan 2010 03:57:15 -0000 X-SWARE-Spam-Status: No, hits=-0.9 required=5.0 tests=AWL,BAYES_00,FH_DATE_PAST_20XX X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 01 Jan 2010 03:57:12 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 8DBA72BAB92; Thu, 31 Dec 2009 22:57:10 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id vlJYORVdcbCH; Thu, 31 Dec 2009 22:57:10 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id F25722BAB8D; Thu, 31 Dec 2009 22:57:09 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 43920F5937; Fri, 1 Jan 2010 04:56:39 +0100 (CET) Date: Fri, 01 Jan 2010 03:57:00 -0000 From: Joel Brobecker To: Jan Kratochvil Cc: gdb-patches@sourceware.org Subject: Re: [patch] testsuite: false MI "unknown output after running" regression Message-ID: <20100101035639.GN2788@adacore.com> References: <20091231221942.GA4039@host0.dyn.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20091231221942.GA4039@host0.dyn.jankratochvil.net> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-01/txt/msg00001.txt.bz2 > gdb/testsuite/ > 2009-12-31 Jan Kratochvil > > * lib/mi-support.exp (mi_expect_stop ): Insert > missing $after_stopped and comma (,) expectation. Phew, it took me a long time to understand how this patch could fix the bad regexp on some of the examples you provided (the after_stop field is empty), because I failed to notice that you added the missing comma. This looks right to me. Please go ahead an apply (I will rotate the ChangeLog et al in a moment). -- Joel