From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29398 invoked by alias); 31 Dec 2009 22:19:52 -0000 Received: (qmail 29387 invoked by uid 22791); 31 Dec 2009 22:19:52 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 31 Dec 2009 22:19:47 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id nBVMJjxP022914 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 31 Dec 2009 17:19:46 -0500 Received: from host0.dyn.jankratochvil.net (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id nBVMJheC009594 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Thu, 31 Dec 2009 17:19:45 -0500 Received: from host0.dyn.jankratochvil.net (localhost [127.0.0.1]) by host0.dyn.jankratochvil.net (8.14.3/8.14.3) with ESMTP id nBVMJhlp004896 for ; Thu, 31 Dec 2009 23:19:43 +0100 Received: (from jkratoch@localhost) by host0.dyn.jankratochvil.net (8.14.3/8.14.3/Submit) id nBVMJgY1004893 for gdb-patches@sourceware.org; Thu, 31 Dec 2009 23:19:42 +0100 Date: Thu, 31 Dec 2009 22:19:00 -0000 From: Jan Kratochvil To: gdb-patches@sourceware.org Subject: [patch] testsuite: false MI "unknown output after running" regression Message-ID: <20091231221942.GA4039@host0.dyn.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.20 (2009-08-17) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-12/txt/msg00473.txt.bz2 Hi, the attached patch will turn the results this way: -KFAIL: gdb.mi/mi-until.exp: until after while loop (unknown output after running) (PRMS: gdb/2104) +KFAIL: gdb.mi/mi-until.exp: until after while loop (stopped at wrong place) (PRMS: gdb/2104) -XFAIL: gdb.mi/mi-watch.exp: sw: watchpoint trigger (unknown output after running) +XFAIL: gdb.mi/mi-watch.exp: sw: watchpoint trigger (stopped at wrong place) -KFAIL: gdb.mi/mi2-until.exp: until after while loop (unknown output after running) (PRMS: gdb/2104) +KFAIL: gdb.mi/mi2-until.exp: until after while loop (stopped at wrong place) (PRMS: gdb/2104) -XFAIL: gdb.mi/mi2-watch.exp: sw: watchpoint trigger (unknown output after running) +XFAIL: gdb.mi/mi2-watch.exp: sw: watchpoint trigger (stopped at wrong place) This is a fix of KFAIL-kind regression due to: commit 26d086d741fb1bb0eee9d50e0bafa7c5e388023f Re: [RFA] fix *stopped for CLI commands http://sourceware.org/ml/gdb-patches/2009-02/msg00278.html http://sourceware.org/ml/gdb-cvs/2009-02/msg00084.html part: gdb/testsuite/ 2009-02-14 Vladimir Prus * lib/mi-support.exp (mi_expect_stop): Adjust the order of fields. (mi_expect_interrupt): Likewise. * gdb.mi/mi-cli.exp: Check that "step" results in proper *stopped response. re-wdiff-ed for your convenience as: verbose -log "mi_expect_stop: expecting: \\*stopped,${r}${a}${bn}[-thread-id=\"$decimal\",stopped-threads=$any,-]frame=\{addr=\"$hex\",func=\"$func\",args=$args,file=\"$any$file\",fullname=\"${fullname_syntax}$file\",line=\"$line\"\}$after_stopped{+,thread-id=\"$decimal\",stopped-threads=$any+}\r\n($thread_selected_re)?$prompt_re" -re "\\*stopped,${r}${a}${bn}[-thread-id=\"$decimal\",stopped-threads=$any,-]frame=\{addr=\"$hex\",func=\"$func\",args=$args,file=\"$any$file\",fullname=\"${fullname_syntax}$file\",line=\"($line)\"\}$after_stopped{+,thread-id=\"$decimal\",stopped-threads=$any+}\r\n($thread_selected_re)?$prompt_re" { -re "\\*stopped,${r}${a}${bn}[-thread-id=\"$decimal\",stopped-threads=$any,-]frame=\{addr=\"$hex\",func=\"$any\",args=\[\\\[\{\]$any\[\\\]\}\],file=\"$any\",fullname=\"${fullname_syntax}$any\",line=\"\[0-9\]*\"\}[-$any-]{+thread-id=\"$decimal\",stopped-threads=$any+}\r\n$prompt_re" { FYI there is: set any "\[^\n\]*" "stopped at wrong place" is the right kind of KFAIL/XFAIL (tested gcc-4.1.2-46.el5_4.1.x86_64 and gcc-4.4.2-20.fc12.x86_64) as discussed in PR gdb/2104. In the last case there is missing comma (,) after the former patch above. $after_stopped was IMO missing there even before. It is in use only by gdb.mi/mi-simplerun.exp and gdb.mi/mi2-simplerun.exp. Also fixed below. No regressions on {x86_64,x86_64-m32,i686}-fedora12-linux-gnu. Thanks, Jan gdb/testsuite/ 2009-12-31 Jan Kratochvil * lib/mi-support.exp (mi_expect_stop ): Insert missing $after_stopped and comma (,) expectation. --- a/gdb/testsuite/lib/mi-support.exp +++ b/gdb/testsuite/lib/mi-support.exp @@ -1038,7 +1038,7 @@ proc mi_expect_stop { reason func args file line extra test } { pass "$test" return $expect_out(2,string) } - -re "\\*stopped,${r}${a}${bn}frame=\{addr=\"$hex\",func=\"$any\",args=\[\\\[\{\]$any\[\\\]\}\],file=\"$any\",fullname=\"${fullname_syntax}$any\",line=\"\[0-9\]*\"\}thread-id=\"$decimal\",stopped-threads=$any\r\n$prompt_re" { + -re "\\*stopped,${r}${a}${bn}frame=\{addr=\"$hex\",func=\"$any\",args=\[\\\[\{\]$any\[\\\]\}\],file=\"$any\",fullname=\"${fullname_syntax}$any\",line=\"\[0-9\]*\"\}$after_stopped,thread-id=\"$decimal\",stopped-threads=$any\r\n$prompt_re" { verbose -log "got $expect_out(buffer)" fail "$test (stopped at wrong place)" return -1