From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8686 invoked by alias); 31 Dec 2009 08:50:09 -0000 Received: (qmail 8669 invoked by uid 22791); 31 Dec 2009 08:50:08 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 31 Dec 2009 08:50:04 +0000 Received: (qmail 3631 invoked from network); 31 Dec 2009 08:50:02 -0000 Received: from unknown (HELO orlando) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 31 Dec 2009 08:50:02 -0000 From: Pedro Alves To: Mark Kettenis Subject: Re: [commit] build failure in inf-ptrace.c (pa-hpux) Date: Thu, 31 Dec 2009 08:50:00 -0000 User-Agent: KMail/1.9.10 Cc: brobecker@adacore.com, stan@codesourcery.com, gdb-patches@sourceware.org References: <20091230194628.GH5942@adacore.com> <200912302007.nBUK7Kc0001012@glazunov.sibelius.xs4all.nl> In-Reply-To: <200912302007.nBUK7Kc0001012@glazunov.sibelius.xs4all.nl> MIME-Version: 1.0 Content-Disposition: inline Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <200912310850.05296.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-12/txt/msg00461.txt.bz2 On Wednesday 30 December 2009 20:07:20, Mark Kettenis wrote: > > Date: Wed, 30 Dec 2009 23:46:28 +0400 > > From: Joel Brobecker > > > > Hello, > > > > inf-ptrace no longer builds on pa-hpux. Looks like a small thinko > > while updating gazillions of files the same way. I hope I fixed it > > right (notice the [...]->pspace = [...]->aspace on the second line > > I changed ;-). I didn't see I first fixed the name of the variable... > > > > 2009-12-30 Joel Brobecker > > > > Fix build failure in inf-ptrace.c. > > * inf-ptrace.c (inf_ptrace_follow_fork): Fix typo. > > > > Checked in. Thanks. On Wednesday 30 December 2009 20:07:20, Mark Kettenis wrote: > > Date: Wed, 30 Dec 2009 23:46:28 +0400 > > From: Joel Brobecker > For what it is worth, it also broke OpenBSD and I came up with the > same fix. You could have said something sooner. ;-) > I'm not sure the fix is right though. > > > + child_inf->pspace = parent_inf->pspace; > > + child_inf->aspace = parent_inf->aspace; > > Looking at the Linux code, this seesm to be right for vfork(), but the > code in inf-ptrace.c handles fork(). > Pedro, Stan, what would be the right thing to do here? It's also what linux does in the "set detach-on-fork on" (default) case when following the child, notice the `|| detach_fork' condition there. Neither OpenBSD nor pa-hpux implement "set detach-on-fork off", that is, don't handle debugging more than inferior simultaneouly, so this is fine. I assume one of you confirmed following a fork works as good as it use to. -- Pedro Alves