Re: [RFA] Fix hw watchpoint count in update_watchpoint

[Joel Brobecker <brobecker@adacore.com>]

> 20090-12-30  Jan Kratochvil  <jan.kratochvil@redhat.com>
> 	     Thiago Jung Bauermann  <bauerman@br.ibm.com>
> 
> 	* breakpoint.c (update_watchpoint): Change b->type to
> 	bp_watchpoint before calling hw_watchpoint_used_count.

Look good, please go ahead and commit.  If I could just expand a little
on your comment, if you don't mind:

> +	    /* Mark as software watchpoint to ensure that this watchpoint
> +	       will not be counted in the hw_watchpoint_used_count call
> +	       below.  */

            /* We need to determine how many resources are already used
               for all other hardware watchpoints to see if we still have 
               enough resources to also fit this watchpoint in as well.
               To avoid the hw_watchpoint_used_count call below from counting
               this watchpoint, make sure that it is marked as a software
               watchpoint.  */

This is only a suggestion, so if you don't like it, please commit your
version, and I'll see if I can suggest an update separately.

Thanks for submitting the patch! (and welcome back, it's been a while)
-- 
Joel