From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24939 invoked by alias); 30 Dec 2009 20:00:31 -0000 Received: (qmail 24929 invoked by uid 22791); 30 Dec 2009 20:00:30 -0000 X-SWARE-Spam-Status: No, hits=-2.7 required=5.0 tests=AWL,BAYES_00,SPF_PASS X-Spam-Check-By: sourceware.org Received: from e24smtp04.br.ibm.com (HELO e24smtp04.br.ibm.com) (32.104.18.25) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 30 Dec 2009 20:00:24 +0000 Received: from mailhub3.br.ibm.com (mailhub3.br.ibm.com [9.18.232.110]) by e24smtp04.br.ibm.com (8.14.3/8.13.1) with ESMTP id nBUJoPoJ022196 for ; Wed, 30 Dec 2009 17:50:25 -0200 Received: from d24av02.br.ibm.com (d24av02.br.ibm.com [9.8.31.93]) by mailhub3.br.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id nBUK2JPS2105598 for ; Wed, 30 Dec 2009 18:02:19 -0200 Received: from d24av02.br.ibm.com (loopback [127.0.0.1]) by d24av02.br.ibm.com (8.14.3/8.13.1/NCO v10.0 AVout) with ESMTP id nBUK0Jkl024621 for ; Wed, 30 Dec 2009 18:00:20 -0200 Received: from hactar.localnet ([9.8.6.18]) by d24av02.br.ibm.com (8.14.3/8.13.1/NCO v10.0 AVin) with ESMTP id nBUK0Jgi024607 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 30 Dec 2009 18:00:19 -0200 From: Thiago Jung Bauermann To: Joel Brobecker Subject: Re: [RFA] Fix verification of changed values for big values. Date: Wed, 30 Dec 2009 20:00:00 -0000 User-Agent: KMail/1.12.2 (Linux/2.6.30-2-686; KDE/4.3.2; i686; ; ) Cc: gdb-patches@sourceware.org, Luis Machado References: <200912232142.37008.bauerman@br.ibm.com> <200912301538.04119.bauerman@br.ibm.com> <20091230192123.GH2788@adacore.com> In-Reply-To: <20091230192123.GH2788@adacore.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <200912301759.36147.bauerman@br.ibm.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-12/txt/msg00448.txt.bz2 On Wed 30 Dec 2009 17:21:23 Joel Brobecker wrote: > > The purpose of the function is rather simple, so I didn't have much to > > say. I added this description: > > > > /* Evaluate watchpoint condition expression and check if its value > > changed. */ > > Thanks. I thought it was important to explain what the real type of > parameter P was so I added an extra sentence to the documentation. > Patch attached. Sorry about that. You mentioned that concern but it slipped my mind somehow. > > You're right. IIRC I used gdb_expect because I wanted to explicitly check > > for the gdb prompt in my regex, to avoid it being too greedy. > > Just for the fun of discussion (I am French, after all :-), I am > pretty sure that you can also do that with gdb_test_multiple... Nice. Thanks for the tip! It's even in the DeveloperTips page of the wiki. I should have known. :-) -- []'s Thiago Jung Bauermann IBM Linux Technology Center