From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20840 invoked by alias); 30 Dec 2009 08:14:17 -0000 Received: (qmail 20829 invoked by uid 22791); 30 Dec 2009 08:14:16 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 30 Dec 2009 08:14:13 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 5301B2BAB64; Wed, 30 Dec 2009 03:14:11 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id gXK-NLFEBArN; Wed, 30 Dec 2009 03:14:11 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id C62422BAB5E; Wed, 30 Dec 2009 03:14:10 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 6A8ACF5937; Wed, 30 Dec 2009 09:13:42 +0100 (CET) Date: Wed, 30 Dec 2009 08:14:00 -0000 From: Joel Brobecker To: Michael Cc: gdb-patches@sourceware.org Subject: Re: patch for testing purposes Message-ID: <20091230081342.GD2788@adacore.com> References: <4B3B07F6.1020604@cyberfiber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4B3B07F6.1020604@cyberfiber.org> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-12/txt/msg00431.txt.bz2 Michael, > does this suffice as a submission for review, or do you suggest an > alternative format? Thank you for sending your contribution. The procedure for contributing is described in gdb/CONTRIBUTE, and I suggestion you give it a read. It was hard to determine how large your contribution really is, because of the diff format you chose (see below). Small obvious contributions can be accepted without copyright assignment. But if you're thinking of making more than one or two small contributions, you need to file a copyright assignment with the FSF. This is briefly explained in the CONTRIBUTE file. Let me know if you'd like to start the process. It takes a few weeks to complete, so the sooner you start it, the better. Just a couple of quick remarks that may not be obvious after you finished reading CONTRIBUTE: > 115,134c115 Your diff does not provide any context, so it's very hard to read. Most maintainers here prefer "unified" diffs (use "diff -u"). Make also sure to use diff option "-p", which also really helps understanding where your patch is changing things. > < // print the status word > < // updated 20091227 (development@codenamezero.org) GDB must follow ISO C 90 (I believe that's the standard we're sticking too), which means comments should use the normal C comment markers. The "updated ..." should go, as this information is available through the version control system. -- Joel