Re: [PATCH 0/2] Support the new PPC476 processor

Joel Brobecker
2009-12-20T13:16:42Z

Sergio,

I did a quick pass over the patch that you sent, and I pretty much
agree with the comments made by Eli. My general comment, is that
the patch is too big for me to really digest as is (3,000 lines in
total!)- maybe it's just me being preoccupied with some many things
going on at the same time. If you'd like to help me review your changes,
I suggest we take a different approach than the one you took to present
these patches: I'd like to have a set of independent patches that implement
each feature independently (that way, I don't have to try to determine
which feature each hunk applies to). We don't have to have them all,
in fact, I'd feel less overwhelmed if we started with just one feature.
For instance, we could look at hardware-accelerated watchpoint conds.
We could look at watchpoint ranges, but we are still discussing the user
interface...

One stylistic comment is that I'm having a hard time with the use of
"point" to mean either breakpoint or watchpoint. I wonder if we could
find something else, but nothing really comes to mind. I am tempted
to say that watchpoints are really data breakpoints while breakpoints
are instruction breakpoints (this is how some documents that I read
called watchpoints: data breakpoints), but perhaps using breakpoint
in this case is going to just be too confusing in the GDB context.
Hmmmm....

--
Joel