From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10680 invoked by alias); 23 Dec 2009 07:08:57 -0000 Received: (qmail 10669 invoked by uid 22791); 23 Dec 2009 07:08:56 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 23 Dec 2009 07:08:50 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 331A32BAAF3 for ; Wed, 23 Dec 2009 02:08:49 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id vf81pWCjZqW3 for ; Wed, 23 Dec 2009 02:08:49 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id AB0BB2BAAE9 for ; Wed, 23 Dec 2009 02:08:48 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 169E1F5937; Wed, 23 Dec 2009 08:08:31 +0100 (CET) Date: Wed, 23 Dec 2009 07:08:00 -0000 From: Joel Brobecker To: gdb-patches@sourceware.org Subject: Re: [RFC] embryo of type/main_type pretty_printing... Message-ID: <20091223070831.GU2788@adacore.com> References: <20091220074121.GG2804@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-12/txt/msg00358.txt.bz2 Thanks, Daniel and Tom, for taking the time to review the script! Once checked in, please feel free to rework/enhance as you see fit. I'll definitely get to it again, but I really want to look at my DW_AT_GNAT_descriptive_type patch, which will make the gnat-stuff thing much simpler. I'm pretty sure the patch is ready, but I want to have another good read + testing before posting. > Regardless of whether you decide to change this, I think you should > check this in. That will make it simpler for us to improve it. I agree that checking it in would be useful. I just don't know where, yet. Should we start a "contrib" directory? Or just in the gdb/ directory itself if we consider this as port of the GDB sources? I had also had questions about whether we want to enable this script by default or not. For now, obviously not, since we really have not finished discussing the output format (not to mention testing). But this affects, IMO, the location where we want to store the script. I was thinking about having the "make" install that script in the build directory besides the gdb exe so that it gets automatically used. Or perhaps we can use a different strategy of adding the source path to one of the search paths that GDB uses... WDYT? -- Joel