From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18401 invoked by alias); 22 Dec 2009 19:45:33 -0000 Received: (qmail 18386 invoked by uid 22791); 22 Dec 2009 19:45:30 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 22 Dec 2009 19:45:26 +0000 Received: from int-mx05.intmail.prod.int.phx2.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.18]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id nBMJjOIK015771 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 22 Dec 2009 14:45:24 -0500 Received: from host0.dyn.jankratochvil.net (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx05.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id nBMJjM1h031486 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 22 Dec 2009 14:45:24 -0500 Received: from host0.dyn.jankratochvil.net (localhost [127.0.0.1]) by host0.dyn.jankratochvil.net (8.14.3/8.14.3) with ESMTP id nBMJjLKu022289; Tue, 22 Dec 2009 20:45:21 +0100 Received: (from jkratoch@localhost) by host0.dyn.jankratochvil.net (8.14.3/8.14.3/Submit) id nBMJjLeu022277; Tue, 22 Dec 2009 20:45:21 +0100 Date: Tue, 22 Dec 2009 19:45:00 -0000 From: Jan Kratochvil To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [patch] Fix breakpoints in unloaded shared libraries Message-ID: <20091222194521.GA22089@host0.dyn.jankratochvil.net> References: <20091025152004.GA14740@host0.dyn.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-08-17) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-12/txt/msg00351.txt.bz2 On Tue, 22 Dec 2009 19:49:44 +0100, Tom Tromey wrote: > >>>>> "Jan" == Jan Kratochvil writes: > > Jan> breakpoints after: > Jan> warning: Temporarily disabling breakpoints for ... > Jan> are currently not handled correctly and GDB does even crash (with > Jan> -lmcheck). > > Jan> 2009-10-25 Jan Kratochvil > Jan> gdb/ > Jan> * breakpoint.c (bpstat_stop_status): Check BL->SHLIB_DISABLED. > Jan> (print_breakpoint_location): New comment. Check LOC->SHLIB_DISABLED. > Jan> Check LOC validity before printing it. Use LOC instead of B->LOC. > Jan> Swap the if conditionals order. > > This is ok. Thanks. The original mail had also the second part: # 2009-10-25 Jan Kratochvil # # gdb/testsuite/ # * gdb.base/unload.c (main): Change the UNLOADSHR parameter to 1. # Replace the printf call of Y by provided "y-set-1" label. New block # for the second shared library. # * gdb.base/unload.exp: Compile also the second library, call # gdb_load_shlibs also for it. Use now gdb_breakpoint. # (single pending breakpoint info): Rename to ... # (pending breakpoint info before run): ... this extended test. # (libfile2, libname2, libsrcfile2, libsrc2) # (lib_sl2): New variables. # (exec_opts): Set also SHLIB_NAME2. # (pending breakpoint info on first run at shrfunc1) # (pending breakpoint info on second run at shrfunc1) # (pending breakpoint info on second run at shrfunc2) # (print y from libfile, print y from libfile2): New tests. # * gdb.base/unloadshr.c (shrfunc1): Change the returned value. # * gdb.base/unloadshr2.c: New. Do I understand it correctly your approval is for the gdb/ part while the gdb/testsuite/ part is still left pending for review some other day? Thanks for the review, Jan