From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6985 invoked by alias); 21 Dec 2009 20:55:40 -0000 Received: (qmail 6975 invoked by uid 22791); 21 Dec 2009 20:55:39 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 21 Dec 2009 20:55:33 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id B0D5C10A5E; Mon, 21 Dec 2009 20:55:31 +0000 (GMT) Received: from caradoc.them.org (209.195.188.212.nauticom.net [209.195.188.212]) by nan.false.org (Postfix) with ESMTP id 970D310548; Mon, 21 Dec 2009 20:55:31 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1NMpHu-0007pY-Ag; Mon, 21 Dec 2009 15:55:30 -0500 Date: Mon, 21 Dec 2009 20:55:00 -0000 From: Daniel Jacobowitz To: Doug Evans Cc: gdb-patches@sourceware.org Subject: Re: [patch] fix tkill_failed gcc warning in gdbserver Message-ID: <20091221205530.GA29538@caradoc.them.org> Mail-Followup-To: Doug Evans , gdb-patches@sourceware.org References: <20091221201033.2B76C84412@ruffy.mtv.corp.google.com> <20091221201921.GA27626@caradoc.them.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-12/txt/msg00324.txt.bz2 On Mon, Dec 21, 2009 at 12:36:13PM -0800, Doug Evans wrote: > The next question is, does gdbserver need to check for > syscall.h/syscall() like gdb does? > Or can I just replace #ifdef SYS_tkill with #ifdef __NR_tkill. > gdbserver includes sys/syscall.h unconditionally, gdb/linux-nat.c does not. > gdb also checks for __NR_tkill in a way that works if it were an enum. > Does one need to worry about that case? I don't know the answers to any of these. But if you have Linux kernel headers, you are going to have __NR_* constants, and I don't know any Linux C library that doesn't have syscall(). If it breaks, we'll fix it :-) -- Daniel Jacobowitz CodeSourcery