From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25135 invoked by alias); 21 Dec 2009 04:38:33 -0000 Received: (qmail 25125 invoked by uid 22791); 21 Dec 2009 04:38:32 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 21 Dec 2009 04:38:29 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 4CB302BAB4C; Sun, 20 Dec 2009 23:38:27 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id zopLTgJzDQfT; Sun, 20 Dec 2009 23:38:27 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 909E52BAB47; Sun, 20 Dec 2009 23:38:26 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id CDCB1F5899; Mon, 21 Dec 2009 05:38:09 +0100 (CET) Date: Mon, 21 Dec 2009 04:38:00 -0000 From: Joel Brobecker To: Michael Snyder Cc: "gdb-patches@sourceware.org" Subject: Re: [ob] fix buf size in amd64_epilogue_frame_cache Message-ID: <20091221043809.GM2788@adacore.com> References: <4B2E762E.7060302@vmware.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4B2E762E.7060302@vmware.com> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-12/txt/msg00287.txt.bz2 > 2009-12-20 Michael Snyder > > * amd64-tdep.c (amd64_epilogue_frame_cache): Fix buf size. I'm going to apply this patch to the gdb-7.0 branch as well. > - gdb_byte buf[4]; > + gdb_byte buf[8]; I think we should try to avoid using litteral constants like these, especially when we repeat that constant later. For instance, in this case, we could have used register_size, or something similar... -- Joel