From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20640 invoked by alias); 16 Dec 2009 07:57:09 -0000 Received: (qmail 20625 invoked by uid 22791); 16 Dec 2009 07:57:08 -0000 X-SWARE-Spam-Status: No, hits=-2.6 required=5.0 tests=BAYES_00,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 16 Dec 2009 07:57:02 +0000 Received: (qmail 7721 invoked from network); 16 Dec 2009 07:57:00 -0000 Received: from unknown (HELO wind.localnet) (vladimir@127.0.0.2) by mail.codesourcery.com with ESMTPA; 16 Dec 2009 07:57:00 -0000 From: Vladimir Prus To: Michael Snyder Subject: Re: GDB MI Reverse Commands added [1 of 3] Date: Wed, 16 Dec 2009 07:57:00 -0000 User-Agent: KMail/1.12.2 (Linux/2.6.31-14-generic-pae; KDE/4.3.2; i686; ; ) Cc: Jakob Engblom , "gdb-patches@sourceware.org" References: <00ce01ca265a$ccb66ca0$662345e0$@com> <4B27E565.5060305@vmware.com> <200912161054.35323.vladimir@codesourcery.com> In-Reply-To: <200912161054.35323.vladimir@codesourcery.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <200912161056.58856.vladimir@codesourcery.com> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-12/txt/msg00202.txt.bz2 On Wednesday 16 December 2009 10:54:35 Vladimir Prus wrote: > On Tuesday 15 December 2009 22:37:09 Michael Snyder wrote: >=20 > > Vladimir, as far as I can tell, this seems to be the most recent > > version of part 1 of this patch, awaiting approval now that the > > copyright paperwork is completed. > >=20 > > 2009-08-31 Tomas Holmberg >th@virtutech.com> > > * mi/mi-main.c: Added the --reverse flag to the following MI > > commands: exec-continue, exec-finish, exec-next, exec-step, > > exec-next-instruction, exec-step-instruction. This is to > > support reverse execution over the MI interface to gdb. >=20 > Michael, >=20 > thanks. This patch is OK, with the following fixes: >=20 > > Index: mi-main.c > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > > RCS file: /cvs/src/src/gdb/mi/mi-main.c,v > > retrieving revision 1.156 > > diff -u -p -r1.156 mi-main.c > > --- mi-main.c 2 Jul 2009 17:25:59 -0000 1.156 > > +++ mi-main.c 27 Aug 2009 01:45:23 -0000 > > @@ -88,8 +88,8 @@ static void mi_cmd_execute (struct mi_pa > >=20=20 > > static void mi_execute_cli_command (const char *cmd, int args_p, > > const char *args); > > -static void mi_execute_async_cli_command (char *cli_command,=20 > > - char **argv, in= t argc); > > +static void mi_execute_async_cli_command (char *cli_command, > > + char **argv, int argc); >=20 > This is spurious formatting change that must be undone. There's a lot of > similar changes in the patch =E2=80=94 that must be similarly undone. >=20 > > +/* continue in reverse direction: > > + XXX: code duplicated from reverse.c */ > > + > > +static void > > +exec_direction_default (void *notused) > > +{ > > + /* Return execution direction to default state. */ > > + execution_direction =3D EXEC_FORWARD; > > +} >=20 > It should be straight-forward to make the function in reverse.c globally > visible, and remove this copy-paste. As a side remark, it's not very good that --reverse should be the first opt= ion to -exec-continue (which takes other options). I'll probably fix that later, a= s I have a patch that touches option parsing. - Volodya