From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17764 invoked by alias); 22 Nov 2009 14:20:52 -0000 Received: (qmail 17748 invoked by uid 22791); 22 Nov 2009 14:20:51 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 22 Nov 2009 14:19:48 +0000 Received: from int-mx03.intmail.prod.int.phx2.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id nAMEIChm001006 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sun, 22 Nov 2009 09:18:12 -0500 Received: from host0.dyn.jankratochvil.net (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx03.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id nAMEI953025080 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sun, 22 Nov 2009 09:18:11 -0500 Received: from host0.dyn.jankratochvil.net (localhost [127.0.0.1]) by host0.dyn.jankratochvil.net (8.14.3/8.14.3) with ESMTP id nAMEI927018377; Sun, 22 Nov 2009 15:18:09 +0100 Received: (from jkratoch@localhost) by host0.dyn.jankratochvil.net (8.14.3/8.14.3/Submit) id nAMEI7a5018373; Sun, 22 Nov 2009 15:18:07 +0100 Date: Sun, 22 Nov 2009 14:20:00 -0000 From: Jan Kratochvil To: "Joseph S. Myers" Cc: gdb-patches@sourceware.org, binutils@sourceware.org, gcc-patches@gcc.gnu.org, Joel Brobecker Subject: Re: Fix ACX_LARGEFILE to use canonical host/target names Message-ID: <20091122141806.GA10982@host0.dyn.jankratochvil.net> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-08-17) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-11/txt/msg00472.txt.bz2 On Fri, 20 Nov 2009 23:38:16 +0100, Joseph S. Myers wrote: > The ACX_LARGEFILE macro checks the values of $host and $target, which > may or may not be canonical names at this point depending on which > other macros have been called first; Missed that, thanks for catching it. > it should require > AC_CANONICAL_HOST and AC_CANONICAL_TARGET to ensure they are both > canonical. This shows up as build failures for GDB configured > --build=i686-pc-linux-gnu --host=i686-solaris2.10 --target=i686-solaris2.10. and so the config/largefile.m4 pattern sparc-*-solaris*|i[3-7]86-*-solaris*) would not match `i686-solaris2.10'. Canonical form of `i686-solaris2.10' after AC_CANONICAL_HOST or AC_CANONICAL_TARGET is `i686-pc-solaris2.10' which would already match the config/largefile.m4 pattern. On native OpenSolaris 2009.06 snv_111b X86 tried that ./configure --host=i386-solaris2.11 --target=i386-solaris2.11; make will fail due to it with: /usr/include/sys/old_procfs.h:57:2: #error "Cannot use procfs in the large file compilation environment" (despite the OS is 64bit the default build targets are 32bit there; as on ppc). While all the subdirectories calling ACX_LARGEFILE already contain AC_CANONICAL_TARGET (equivalent form AC_CANONICAL_SYSTEM is not present there) none of them explicitly calls AC_CANONICAL_HOST, bfd/ already contains it (by ../ltoptions.m4) but gdb/ does not - which causes the compilation error. > with regeneration of the GDB and binutils configure scripts that use > ACX_LARGEFILE? I would like to get regenerated all the subdirectories calling ACX_LARGEFILE (bfd/ binutils/ gas/ gprof/ ld/ gdb/) as the common config/largefile.m4 file purpose was exactly to get all the subdirectories ABI compatible, as described in the mails introducing ACX_LARGEFILE. Thanks, Jan