From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4597 invoked by alias); 20 Nov 2009 16:01:43 -0000 Received: (qmail 4374 invoked by uid 22791); 20 Nov 2009 16:01:41 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 20 Nov 2009 16:00:38 +0000 Received: (qmail 29221 invoked from network); 20 Nov 2009 16:00:36 -0000 Received: from unknown (HELO orlando) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 20 Nov 2009 16:00:36 -0000 From: Pedro Alves To: Jan Kratochvil Subject: Re: Fix regression in always-inserted breakpoints mode. Date: Fri, 20 Nov 2009 16:01:00 -0000 User-Agent: KMail/1.9.10 Cc: gdb-patches@sourceware.org References: <200911200211.18854.pedro@codesourcery.com> <20091120113821.GA30659@host0.dyn.jankratochvil.net> In-Reply-To: <20091120113821.GA30659@host0.dyn.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200911201600.37742.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-11/txt/msg00435.txt.bz2 On Friday 20 November 2009 11:38:21, Jan Kratochvil wrote: > On Fri, 20 Nov 2009 03:11:18 +0100, Pedro Alves wrote: > > There's for loop a bit below, that starts iterating on > > `locp', and that would misses a few locations, > > I agree I brought in such regression, thanks for catching it. > > I will check-in the [obv] patch below after you check it in. Good idea. I've checked mine in. Go ahead. > > There's another problem with this for loop. The > > breakpoint_address_match is too strict when debugging > > more than one inferior. Even if breakpoint_address_match > > fails due to address space mismatch, there could be other > > locations with the same address following loc2p. > > This is unrelated to the regression from me. We were always looping over all locations previously, and breakpoint_address_match wasn't a part of the for loop conditional, so it is. But that's okay, it doesn't matter, regressions happen. I was just looking for an extra pair of eyes that knows this new code. -- Pedro Alves