From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-68484-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 15844 invoked by alias); 17 Nov 2009 19:40:17 -0000
Received: (qmail 15835 invoked by uid 22791); 17 Nov 2009 19:40:16 -0000
X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 	tests=AWL,BAYES_00
X-Spam-Check-By: sourceware.org
Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 17 Nov 2009 19:39:12 +0000
Received: from localhost (localhost.localdomain [127.0.0.1]) 	by filtered-rock.gnat.com (Postfix) with ESMTP id 54CBC2BAC0E; 	Tue, 17 Nov 2009 14:39:10 -0500 (EST)
Received: from rock.gnat.com ([127.0.0.1]) 	by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) 	with LMTP id Rnik5lCDEMC3; Tue, 17 Nov 2009 14:39:10 -0500 (EST)
Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) 	by rock.gnat.com (Postfix) with ESMTP id 312222BAB52; 	Tue, 17 Nov 2009 14:39:10 -0500 (EST)
Received: by joel.gnat.com (Postfix, from userid 1000) 	id B29E1F5905; Tue, 17 Nov 2009 14:39:09 -0500 (EST)
Date: Tue, 17 Nov 2009 19:40:00 -0000
From: Joel Brobecker <brobecker@adacore.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org, Joost van der Sluis <joost@cnoc.nl>
Subject: Re: [patch] Fix crash on reading stabs
Message-ID: <20091117193908.GB5266@adacore.com>
References: <20091117162958.GA827@host0.dyn.jankratochvil.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20091117162958.GA827@host0.dyn.jankratochvil.net>
User-Agent: Mutt/1.5.18 (2008-05-17)
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2009-11/txt/msg00391.txt.bz2

> If it isn't obviously approved please feel free to drop it as one
> should not use STABS in the first place.

Agreed. Anyone using stabs should be paying us a tithe...

That being said:

> gdb/
> 2009-11-17  Jan Kratochvil  <jan.kratochvil@redhat.com>
> 
> 	* dbxread.c (set_namestring): Remove cast to unsigned.  Check N_STRX
> 	overflow.

This patch looks fine.

-- 
Joel