From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20580 invoked by alias); 13 Nov 2009 19:12:47 -0000 Received: (qmail 20572 invoked by uid 22791); 13 Nov 2009 19:12:46 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 13 Nov 2009 19:12:39 +0000 Received: (qmail 28254 invoked from network); 13 Nov 2009 19:12:37 -0000 Received: from unknown (HELO localhost) (froydnj@127.0.0.2) by mail.codesourcery.com with ESMTPA; 13 Nov 2009 19:12:37 -0000 Date: Fri, 13 Nov 2009 19:12:00 -0000 From: Nathan Froyd To: gdb-patches@sourceware.org Subject: [PATCH,testsuite] fix pending.exp failure with remote targets Message-ID: <20091113191236.GM31393@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.13 (2006-08-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-11/txt/msg00300.txt.bz2 The patch below fixes a problem with pending.exp. pending.exp uses a bare 'run' to start execution of the test, which is not appropriate for remote targets like gdbserver. The patch fixes this by using gdb_run_cmd to start execution of the test. Tested with cross to powerpc-linux-gnu. OK to commit? -Nathan * gdb.base/pending.exp: Use gdb_run_cmd to start the program instead of a bare "run". Index: gdb.base/pending.exp =================================================================== RCS file: /cvs/src/src/gdb/testsuite/gdb.base/pending.exp,v retrieving revision 1.16 diff -u -u -r1.16 pending.exp --- gdb.base/pending.exp 3 Jan 2009 05:58:03 -0000 1.16 +++ gdb.base/pending.exp 13 Nov 2009 19:10:19 -0000 @@ -71,7 +71,10 @@ gdb_load_shlibs $lib_sl set pendfunc1_loc [gdb_get_line_number "y = x + 4" ${libfile}.c] -gdb_test "run" \ + +gdb_run_cmd + +gdb_test "" \ ".*Breakpoint.*pendfunc1.*at.*pendshr.c:$pendfunc1_loc.*y = x \\+ 4.*" \ "run to resolved breakpoint 1 (without symbols)"