Re: [PATCH] gcore registers storing fix

Daniel Gutson
2009-11-09T18:17:54Z

Daniel Jacobowitz wrote:
> On Mon, Nov 09, 2009 at 11:59:26AM -0300, Daniel Gutson wrote:
>>> You say in your comment, "The threads should be standing at a
>>> known function, rather than ??". I'm not sure how we can know
>>> that. The threads may have been stopped anywhere, and it's
>>> always possible to find a library with no symbols.
>> What would you suggest? I could bound the check to the current frame.
>
> How about we check that at least one thread is in "thread2"? That's
> where gcore was used to create the core file. Except, there's already
> a test for that in the file. So maybe we do not need a new test.

The problem shows up when "in ??" appears. I think that the current
thread will never be shown in that way unless the test does fail.
That being said, I think that I could add the regex for the "*" in order
to looking into the current thread only.

Thoughts?

Thanks,
Daniel.

--
Daniel Gutson
CodeSourcery