From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27172 invoked by alias); 9 Nov 2009 22:05:26 -0000 Received: (qmail 27163 invoked by uid 22791); 9 Nov 2009 22:05:25 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 09 Nov 2009 22:05:21 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id E2A3B2BAC73; Mon, 9 Nov 2009 17:05:19 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 4BZAxnPui3Yu; Mon, 9 Nov 2009 17:05:19 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id A54A92BAC70; Mon, 9 Nov 2009 17:05:19 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 354D2F5905; Mon, 9 Nov 2009 14:05:04 -0800 (PST) Date: Mon, 09 Nov 2009 22:05:00 -0000 From: Joel Brobecker To: S?bastien Granjoux Cc: gdb-patches@sourceware.org Subject: Re: Fix breakpoints when several source files have the same name Message-ID: <20091109220504.GU4557@adacore.com> References: <4AF87BF4.5040303@free.fr> <20091109210849.GS4557@adacore.com> <4AF88BB4.2030101@free.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4AF88BB4.2030101@free.fr> User-Agent: Mutt/1.5.18 (2008-05-17) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-11/txt/msg00194.txt.bz2 > 2009-11-09 Sebastien Granjoux > > PR mi/9583: > * symtab.c (find_line_symtab, append_exact_match_to_sals) > (expand_line_sal): Use full filename when setting breakpoints if > available I have now checked that patch in for you. Just one tiny little nit that I corrected: 2 spaces before your email address. You are now eligible for "Write After Approval". See gdb/MAINTAINERS for more details. If you think you'll be contributing more patches to GDB, it would be a good idea for you to have write access to the GDB repository. Let me know if this is something you're interested in. -- Joel