From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10381 invoked by alias); 9 Nov 2009 21:11:13 -0000 Received: (qmail 10370 invoked by uid 22791); 9 Nov 2009 21:11:11 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 09 Nov 2009 21:11:06 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id C2ED82BABA7; Mon, 9 Nov 2009 16:11:04 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id HK9QBxmNvvJi; Mon, 9 Nov 2009 16:11:04 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 74A4B2BAB38; Mon, 9 Nov 2009 16:11:04 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 618F3F5905; Mon, 9 Nov 2009 13:10:49 -0800 (PST) Date: Mon, 09 Nov 2009 21:11:00 -0000 From: Joel Brobecker To: Tom Tromey Cc: Jon Beniston , gdb-patches@sourceware.org Subject: Re: [PATCH] Don't split executable paths with spaces in into multiple arguments Message-ID: <20091109211049.GT4557@adacore.com> References: <003c01ca5d52$1715da50$45418ef0$@com> <20091104161727.GH4557@adacore.com> <20091109174623.GR4557@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.18 (2008-05-17) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-11/txt/msg00185.txt.bz2 > In this particular case, though, I would probably have pushed back a > bit, first because the patch is already fixing a previous "can't happen" > assumption, and second because the correct code is really just 4 or 5 > lines. (I thought for sure we would already have the quoting code lying > around, but I grepped a little and couldn't find it. It is odd that we > have buildargv to split the argv but nothing to quote it.) I understand. Jon, Would you mind enhancing your patch to handle all cases properly, please? Thanks, -- Joel