From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 437 invoked by alias); 7 Nov 2009 11:02:25 -0000 Received: (qmail 342 invoked by uid 22791); 7 Nov 2009 11:02:24 -0000 X-SWARE-Spam-Status: No, hits=-2.6 required=5.0 tests=BAYES_00,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 07 Nov 2009 11:02:20 +0000 Received: (qmail 22837 invoked from network); 7 Nov 2009 11:02:18 -0000 Received: from unknown (HELO wind.localnet) (vladimir@127.0.0.2) by mail.codesourcery.com with ESMTPA; 7 Nov 2009 11:02:18 -0000 From: Vladimir Prus To: Mark Kettenis Subject: Re: [m68k] correct m68k_convert_register_p for coldfire Date: Sat, 07 Nov 2009 11:02:00 -0000 User-Agent: KMail/1.12.90 (Linux/2.6.24-25-generic; KDE/4.3.73; i686; svn-1043485; 2009-11-01) Cc: gdb-patches@sources.redhat.com References: <200911061604.18419.vladimir@codesourcery.com> <200911062325.nA6NPZHv008499@glazunov.sibelius.xs4all.nl> In-Reply-To: <200911062325.nA6NPZHv008499@glazunov.sibelius.xs4all.nl> MIME-Version: 1.0 Content-Type: Text/Plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Message-Id: <200911071402.19931.vladimir@codesourcery.com> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-11/txt/msg00123.txt.bz2 On Saturday 07 November 2009 Mark Kettenis wrote: > > From: Vladimir Prus > > Date: Fri, 06 Nov 2009 20:24:47 +0300 > > > Please don't apply this as is without at least trying to > > > build it... current_gdbarch doesn't exist anymore. > > > > Doh! Here's what I've ended up checking it. > > But that doesn't make any sense. On a real m68k, > register_type(gdbarch, M68K_FP0_REGNUM) will return > m68881_ext_type(gdbarch) and on coldfire, type != > m68881_ext_type(gdbarch) is probably always true. Does the correction in http://sourceware.org/ml/gdb-cvs/2009-11/msg00044.html make the code sensible? - Volodya