From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9596 invoked by alias); 5 Nov 2009 20:03:02 -0000 Received: (qmail 9504 invoked by uid 22791); 5 Nov 2009 20:03:01 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 05 Nov 2009 20:02:56 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 90E2510EC9; Thu, 5 Nov 2009 20:02:54 +0000 (GMT) Received: from caradoc.them.org (209.195.188.212.nauticom.net [209.195.188.212]) by nan.false.org (Postfix) with ESMTP id 7518810EA9; Thu, 5 Nov 2009 20:02:54 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1N68Xk-0004rV-QJ; Thu, 05 Nov 2009 15:02:52 -0500 Date: Thu, 05 Nov 2009 20:03:00 -0000 From: Daniel Jacobowitz To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: FYI: minor simplification in add_psymbol_to_bcache Message-ID: <20091105200252.GA18502@caradoc.them.org> Mail-Followup-To: Tom Tromey , gdb-patches@sourceware.org References: <20091103202058.GA23081@caradoc.them.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-11/txt/msg00098.txt.bz2 On Wed, Nov 04, 2009 at 12:16:27PM -0700, Tom Tromey wrote: > TBH I was not thinking too soundly, I suppose, when I nuked this. I > think your point is a good one. If you'd prefer, I will leave this > static and just zero out that field. Unless you have a good reason not to, I suggest making that change. -- Daniel Jacobowitz CodeSourcery