From: Joel Brobecker <brobecker@adacore.com>
To: Jon Beniston <jon@beniston.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Don't split executable paths with spaces in into multiple arguments
Date: Wed, 04 Nov 2009 16:17:00 -0000 [thread overview]
Message-ID: <20091104161727.GH4557@adacore.com> (raw)
In-Reply-To: <003c01ca5d52$1715da50$45418ef0$@com>
> gdb/
> 2009-11-04 Jon Beniston <jon@beniston.com>
>
> * remote-sim.c(gdbsim_create_inferior) Quote executable path in case
> it
> contains spaces.
OK. This is not handling the case where the filename contains a double
quote, but it is not making things worse, and double-quotes in filenames
are probably extremely rare.
Just a tiny formatting request: Please add a space before
"(gdbsim_create_inferior)" and make sure that each line does not
exceed 80 character.
> - len = strlen (exec_file) + 1 + strlen (args) + 1 + /*slop */ 10;
> + len = 2 + strlen (exec_file) + 1 + strlen (args) + 1 + /*slop */ 10;
This is not your doing, but the remote-sim code is full of "slop" and
"slack", etc, and I wonder how hard it would be to make it crash due
to not enough "slack" :-(.
--
Joel
next prev parent reply other threads:[~2009-11-04 16:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-04 13:26 Jon Beniston
2009-11-04 16:17 ` Joel Brobecker [this message]
2009-11-09 17:42 ` Tom Tromey
2009-11-09 17:46 ` Joel Brobecker
2009-11-09 18:04 ` Tom Tromey
2009-11-09 21:11 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091104161727.GH4557@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=jon@beniston.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox