From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16265 invoked by alias); 3 Nov 2009 23:08:23 -0000 Received: (qmail 16241 invoked by uid 22791); 3 Nov 2009 23:08:22 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 03 Nov 2009 23:08:15 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id D51E510EAA; Tue, 3 Nov 2009 23:08:13 +0000 (GMT) Received: from caradoc.them.org (209.195.188.212.nauticom.net [209.195.188.212]) by nan.false.org (Postfix) with ESMTP id B48EB10EA2; Tue, 3 Nov 2009 23:08:13 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1N5SU0-0002Q8-W7; Tue, 03 Nov 2009 18:08:12 -0500 Date: Tue, 03 Nov 2009 23:08:00 -0000 From: Daniel Jacobowitz To: Maxim Kuvyrkov Cc: gdb-patches@sourceware.org, Andreas Schwab Subject: Re: [PATCH, M68K] Handle TLS Message-ID: <20091103230812.GA8761@caradoc.them.org> Mail-Followup-To: Maxim Kuvyrkov , gdb-patches@sourceware.org, Andreas Schwab References: <4AF05659.1070404@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4AF05659.1070404@codesourcery.com> User-Agent: Mutt/1.5.20 (2009-06-14) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-11/txt/msg00068.txt.bz2 On Tue, Nov 03, 2009 at 07:12:09PM +0300, Maxim Kuvyrkov wrote: > Hi, > > The following simple patch adds handling of TLS to m68k gdbserver. > > A corresponding kernel patch is being reviewed here > . > > Tested on coldfire-linux. > > OK to apply? This is fine with two caveats: * I think it would be best to not apply it until you have an ack for the kernel patch defining PTRACE_GET_THREAD_AREA. * Provide a fallback definition for PTRACE_GET_THREAD_AREA. I assume existing m68k kernel headers do not define it, so the build would fail. -- Daniel Jacobowitz CodeSourcery