From: Daniel Jacobowitz <drow@false.org>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: RFC: Simplify partial dies
Date: Mon, 02 Nov 2009 19:50:00 -0000 [thread overview]
Message-ID: <20091102194956.GB6842@caradoc.them.org> (raw)
In-Reply-To: <m37hu8g1af.fsf@fleche.redhat.com>
[Sorry about the dupe, Tom.]
On Mon, Nov 02, 2009 at 12:43:52PM -0700, Tom Tromey wrote:
> >>>>> "Daniel" == Daniel Jacobowitz <drow@false.org> writes:
>
> Daniel> - if (comp_unit_die.dirname)
> Daniel> - pst->dirname = obsavestring (comp_unit_die.dirname,
> Daniel> - strlen (comp_unit_die.dirname),
> Daniel> + attr = dwarf2_attr (comp_unit_die, DW_AT_comp_dir, &cu);
> Daniel> + if (attr != NULL)
> Daniel> + pst->dirname = obsavestring (DW_STRING (attr),
> Daniel> + strlen (DW_STRING (attr)),
> Daniel> &objfile->objfile_obstack);
>
> Is this obsavestring actually needed? I thought a DW_STRING value
> necessarily had to live as long as the symbol tables, so did not need to
> be copied; but if that isn't so, I would like to know.
Good point. I'm not sure about the one before my patch, but after I'm
confident you're right.
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2009-11-02 19:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-02 15:26 Daniel Jacobowitz
2009-11-02 19:44 ` Tom Tromey
2009-11-02 19:50 ` Daniel Jacobowitz [this message]
2009-11-05 23:18 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091102194956.GB6842@caradoc.them.org \
--to=drow@false.org \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox