Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: gdb-patches@sourceware.org
Cc: Keith Seitz <keiths@redhat.com>
Subject: [commit] Fix up return values in ctti.exp
Date: Mon, 02 Nov 2009 15:55:00 -0000	[thread overview]
Message-ID: <20091102155545.GA14328@caradoc.them.org> (raw)

This test is bit-rotten because it is disabled for GCC.  It still
doesn't pass with GCC, so I left it disabled, but I hope that Keith's
branch will resolve this.

Meanwhile, while trying it with local patches for RealView compiler
support, I discovered that the exp file expects some functions to
return -126 when their return type is "unsigned char".  It should be
130 instead.

Checked in.

-- 
Daniel Jacobowitz
CodeSourcery

2009-11-02  Daniel Jacobowitz  <dan@codesourcery.com>

	* gdb.cp/ctti.exp: Correct return values for unsigned char functions.

---
 gdb/testsuite/gdb.cp/ctti.exp |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

Index: gdb-mainline/gdb/testsuite/gdb.cp/ctti.exp
===================================================================
--- gdb-mainline.orig/gdb/testsuite/gdb.cp/ctti.exp	2009-01-02 21:58:04.000000000 -0800
+++ gdb-mainline/gdb/testsuite/gdb.cp/ctti.exp	2009-10-31 07:02:05.000000000 -0700
@@ -112,7 +112,7 @@ gdb_test_multiple "print add<float>(2.25
 }
 
 gdb_test_multiple "print add<unsigned char>('A','A')" "print add<unsigned char>('A','A')" {
-    -re "\\$\[0-9\]+ = -126 .*\r\n$gdb_prompt $" {
+    -re "\\$\[0-9\]+ = 130 .*\r\n$gdb_prompt $" {
 	pass "print add<unsigned char>('A','A')"
     }
     -re "No symbol \"add<unsigned char>\" in current context.\r\n$gdb_prompt $" {
@@ -142,7 +142,7 @@ gdb_test_multiple "print add2<float>(2.2
 }
 
 gdb_test_multiple "print add2<unsigned char>('A','A')" "print add2<unsigned char>('A','A')" {
-    -re "\\$\[0-9]+ = -126 .*$gdb_prompt $" {
+    -re "\\$\[0-9]+ = 130 .*$gdb_prompt $" {
 	pass "print add2<unsigned char>('A','A')"
     }
     -re "No symbol \"add2<unsigned char>\" in current context.\r\n$gdb_prompt $" {
@@ -172,7 +172,7 @@ gdb_test_multiple "print add3<float>(2.2
 }
 
 gdb_test_multiple "print add3<unsigned char>('A','A')" "print add3<unsigned char>('A','A')" {
-    -re "\\$\[0-9]+ = -126 .*$gdb_prompt $" {
+    -re "\\$\[0-9]+ = 130 .*$gdb_prompt $" {
 	pass "print add3<unsigned char>('A','A')"
     }
     -re "No symbol \"add3<unsigned char>\" in current context.\r\n$gdb_prompt $" {
@@ -202,7 +202,7 @@ gdb_test_multiple "print add4<float>(2.2
 }
 
 gdb_test_multiple "print add4<unsigned char>('A','A')" "print add4<unsigned char>('A','A')" {
-    -re "\\$\[0-9]+ = -126 .*$gdb_prompt $" {
+    -re "\\$\[0-9]+ = 130 .*$gdb_prompt $" {
 	pass "print add4<unsigned char>('A','A')"
     }
     -re "No symbol \"add4<unsigned char>\" in current context.\r\n$gdb_prompt $" {


             reply	other threads:[~2009-11-02 15:55 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-02 15:55 Daniel Jacobowitz [this message]
2009-11-09 23:51 ` Keith Seitz
2009-11-10 19:15   ` Daniel Jacobowitz
2009-11-10 22:21     ` Keith Seitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091102155545.GA14328@caradoc.them.org \
    --to=drow@false.org \
    --cc=gdb-patches@sourceware.org \
    --cc=keiths@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox