From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7038 invoked by alias); 2 Nov 2009 14:51:19 -0000 Received: (qmail 7019 invoked by uid 22791); 2 Nov 2009 14:51:18 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 02 Nov 2009 14:51:12 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id nA2Ep29H006034; Mon, 2 Nov 2009 09:51:03 -0500 Received: from host0.dyn.jankratochvil.net (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id nA2Ep11P029655 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 2 Nov 2009 09:51:02 -0500 Received: from host0.dyn.jankratochvil.net (localhost [127.0.0.1]) by host0.dyn.jankratochvil.net (8.14.3/8.14.3) with ESMTP id nA2Ep0xh005087; Mon, 2 Nov 2009 15:51:00 +0100 Received: (from jkratoch@localhost) by host0.dyn.jankratochvil.net (8.14.3/8.14.3/Submit) id nA2EoxUf005086; Mon, 2 Nov 2009 15:50:59 +0100 Date: Mon, 02 Nov 2009 14:51:00 -0000 From: Jan Kratochvil To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [patch] cleanup: Remove INVALID_ENTRY_POINT (+FR-V modification) Message-ID: <20091102145059.GA4915@host0.dyn.jankratochvil.net> References: <20091031150829.GA27608@host0.dyn.jankratochvil.net> <200910311542.13318.pedro@codesourcery.com> <20091031195053.GA9955@host0.dyn.jankratochvil.net> <200910312108.28983.pedro@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200910312108.28983.pedro@codesourcery.com> User-Agent: Mutt/1.5.20 (2009-08-17) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-11/txt/msg00019.txt.bz2 On Sat, 31 Oct 2009 22:08:28 +0100, Pedro Alves wrote: > > 2009-10-31 Jan Kratochvil > > > > Remove INVALID_ENTRY_POINT. > > * frame.c (inside_entry_func): New variable entry_point. Return 0 if > > the entry point is not known. > > * solib-irix.c (enable_break): Likewise. > > * objfiles.c (init_entry_point_info): Stop using INVALID_ENTRY_POINT. > > Initialize EI.ENTRY_POINT_P. > > (entry_point_address): Rename to ... > > (entry_point_address_query): ... a new function. Use EI.ENTRY_POINT_P. > > (entry_point_address): New function. > > (objfile_relocate): Use EI.ENTRY_POINT_P. > > * objfiles.h (struct entry_info): Simplify entry_point comment. New > > field entry_point_p. > > (INVALID_ENTRY_POINT): Remove. > > (entry_point_address_query): New prototype. > > * solib-frv.c (enable_break): Check for NULL SYMFILE_OBJFILE and its > > EI.ENTRY_POINT_P. Return 0 if ".interp" is not found. > > Looks OK to me. Checked-in: http://sourceware.org/ml/gdb-cvs/2009-11/msg00006.html Thanks, Jan