From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31724 invoked by alias); 2 Nov 2009 00:57:05 -0000 Received: (qmail 31715 invoked by uid 22791); 2 Nov 2009 00:57:04 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 02 Nov 2009 00:57:00 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 9290410D7F; Mon, 2 Nov 2009 00:56:58 +0000 (GMT) Received: from caradoc.them.org (209.195.188.212.nauticom.net [209.195.188.212]) by nan.false.org (Postfix) with ESMTP id 7BC2F10D7C; Mon, 2 Nov 2009 00:56:58 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1N4lE9-0007hB-0u; Sun, 01 Nov 2009 19:56:57 -0500 Date: Mon, 02 Nov 2009 00:57:00 -0000 From: Daniel Jacobowitz To: Michael Snyder Cc: "gdb-patches@sourceware.org" Subject: Re: [RFA] comment looks wrong... Message-ID: <20091102005657.GA29533@caradoc.them.org> Mail-Followup-To: Michael Snyder , "gdb-patches@sourceware.org" References: <4AE89A1F.2080502@vmware.com> <20091028200435.GA13464@caradoc.them.org> <4AEDD14C.4080505@vmware.com> <20091101193312.GA31647@caradoc.them.org> <4AEDF1AE.9040402@vmware.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4AEDF1AE.9040402@vmware.com> User-Agent: Mutt/1.5.20 (2009-06-14) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-11/txt/msg00013.txt.bz2 On Sun, Nov 01, 2009 at 12:38:06PM -0800, Michael Snyder wrote: > +/* Basic byte-swapping routines. GDB has needed these for a long > + time... All 'extract' functions return a host-format integer > + from a target-format integer ADDR which is LEN bytes long. */ I suggest dropping the long time comment, and putting back the lost "at": /* Basic byte-swapping routines. All 'extract' functions return a host-format integer from a target-format integer at ADDR which is LEN bytes long. */ How's that? -- Daniel Jacobowitz CodeSourcery