From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1319 invoked by alias); 31 Oct 2009 14:57:24 -0000 Received: (qmail 1282 invoked by uid 22791); 31 Oct 2009 14:57:21 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 31 Oct 2009 14:57:17 +0000 Received: (qmail 17295 invoked from network); 31 Oct 2009 14:57:15 -0000 Received: from unknown (HELO orlando.local) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 31 Oct 2009 14:57:15 -0000 From: Pedro Alves To: gdb-patches@sourceware.org Subject: Re: [RFA, 3 of 3] save/restore process record, part 3 (save/restore) Date: Sat, 31 Oct 2009 14:57:00 -0000 User-Agent: KMail/1.9.10 Cc: Hui Zhu , msnyder@vmware.com References: <4AD91D72.1030802@vmware.com> <200910231554.12387.pedro@codesourcery.com> In-Reply-To: <200910231554.12387.pedro@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Message-Id: <200910311457.58034.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-10/txt/msg00705.txt.bz2 On Friday 23 October 2009 15:54:11, Pedro Alves wrote: > On Friday 23 October 2009 15:42:00, Hui Zhu wrote: > > =A0 =A0if (record_debug) > > =A0 =A0 =A0printf_filtered ("\ >=20 > All debug output should go to fprintf_unfiltered (gdb_stdlog, ... > not printf_filtered. >=20 Applied. --=20 Pedro Alves 2009-10-31 Pedro Alves * record.c (record_restore, cmd_record_save): Debug output goes to gdb_stdlog. --- gdb/record.c | 87 +++++++++++++++++++++++++++++-------------------------= ----- 1 file changed, 44 insertions(+), 43 deletions(-) Index: src/gdb/record.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- src.orig/gdb/record.c 2009-10-26 17:09:38.000000000 +0000 +++ src/gdb/record.c 2009-10-31 14:45:19.000000000 +0000 @@ -2005,18 +2005,18 @@ record_restore (void) gdb_assert (record_first.next =3D=3D NULL); =20=20 if (record_debug) - printf_filtered ("Restoring recording from core file.\n"); + fprintf_unfiltered (gdb_stdlog, "Restoring recording from core file.\n= "); =20 /* Now need to find our special note section. */ osec =3D bfd_get_section_by_name (core_bfd, "null0"); osec_size =3D bfd_section_size (core_bfd, osec); if (record_debug) - printf_filtered ("Find precord section %s.\n", - osec ? "succeeded" : "failed"); - if (!osec) + fprintf_unfiltered (gdb_stdlog, "Find precord section %s.\n", + osec ? "succeeded" : "failed"); + if (osec =3D=3D NULL) return; if (record_debug) - printf_filtered ("%s", bfd_section_name (core_bfd, osec)); + fprintf_unfiltered (gdb_stdlog, "%s", bfd_section_name (core_bfd, osec= )); =20 /* Check the magic code. */ bfdcore_read (core_bfd, osec, &magic, sizeof (magic), &bfd_offset); @@ -2024,9 +2024,9 @@ record_restore (void) error (_("Version mis-match or file format error in core file %s."), bfd_get_filename (core_bfd)); if (record_debug) - printf_filtered ("\ + fprintf_unfiltered (gdb_stdlog, "\ Reading 4-byte magic cookie RECORD_FILE_MAGIC (0x%s)\n", - phex_nz (netorder32 (magic), 4)); + phex_nz (netorder32 (magic), 4)); =20 /* Restore the entries in recfd into record_arch_list_head and record_arch_list_tail. */ @@ -2062,12 +2062,12 @@ record_restore (void) bfdcore_read (core_bfd, osec, record_get_loc (rec), rec->u.reg.len, &bfd_offset); =20 - if (record_debug) - printf_filtered ("\ + if (record_debug) + fprintf_unfiltered (gdb_stdlog, "\ Reading register %d (1 plus %lu plus %d bytes)\n", - rec->u.reg.num, - (unsigned long) sizeof (regnum), - rec->u.reg.len); + rec->u.reg.num, + (unsigned long) sizeof (regnum), + rec->u.reg.len); break; =20 case record_mem: /* mem */ @@ -2087,14 +2087,14 @@ record_restore (void) bfdcore_read (core_bfd, osec, record_get_loc (rec), rec->u.mem.len, &bfd_offset); =20 - if (record_debug) - printf_filtered ("\ + if (record_debug) + fprintf_unfiltered (gdb_stdlog, "\ Reading memory %s (1 plus %lu plus %lu plus %d bytes)\n", - paddress (get_current_arch (), - rec->u.mem.addr), - (unsigned long) sizeof (addr), - (unsigned long) sizeof (len), - rec->u.mem.len); + paddress (get_current_arch (), + rec->u.mem.addr), + (unsigned long) sizeof (addr), + (unsigned long) sizeof (len), + rec->u.mem.len); break; =20 case record_end: /* end */ @@ -2113,13 +2113,13 @@ record_restore (void) count =3D netorder32 (count); rec->u.end.insn_num =3D count; record_insn_count =3D count + 1; - if (record_debug) - printf_filtered ("\ + if (record_debug) + fprintf_unfiltered (gdb_stdlog, "\ Reading record_end (1 + %lu + %lu bytes), offset =3D=3D %s\n", - (unsigned long) sizeof (signal), - (unsigned long) sizeof (count), - paddress (get_current_arch (), - bfd_offset)); + (unsigned long) sizeof (signal), + (unsigned long) sizeof (count), + paddress (get_current_arch (), + bfd_offset)); break; =20 default: @@ -2225,7 +2225,8 @@ cmd_record_save (char *args, int from_tt =20 /* Open the save file. */ if (record_debug) - printf_filtered ("Saving execution log to core file '%s'\n", recfilena= me); + fprintf_unfiltered (gdb_stdlog, "Saving execution log to core file '%s= '\n", + recfilename); =20 /* Open the output file. */ obfd =3D create_gcore_bfd (recfilename); @@ -2291,9 +2292,9 @@ cmd_record_save (char *args, int from_tt /* Write the magic code. */ magic =3D RECORD_FILE_MAGIC; if (record_debug) - printf_filtered ("\ + fprintf_unfiltered (gdb_stdlog, "\ Writing 4-byte magic cookie RECORD_FILE_MAGIC (0x%s)\n", - phex_nz (magic, 4)); + phex_nz (magic, 4)); bfdcore_write (obfd, osec, &magic, sizeof (magic), &bfd_offset); =20 /* Save the entries to recfd and forward execute to the end of @@ -2314,12 +2315,12 @@ cmd_record_save (char *args, int from_tt switch (record_list->type) { case record_reg: /* reg */ - if (record_debug) - printf_filtered ("\ + if (record_debug) + fprintf_unfiltered (gdb_stdlog, "\ Writing register %d (1 plus %lu plus %d bytes)\n", - record_list->u.reg.num, - (unsigned long) sizeof (regnum), - record_list->u.reg.len); + record_list->u.reg.num, + (unsigned long) sizeof (regnum), + record_list->u.reg.len); =20 /* Write regnum. */ regnum =3D netorder32 (record_list->u.reg.num); @@ -2333,13 +2334,13 @@ cmd_record_save (char *args, int from_tt =20 case record_mem: /* mem */ if (record_debug) - printf_filtered ("\ + fprintf_unfiltered (gdb_stdlog, "\ Writing memory %s (1 plus %lu plus %lu plus %d bytes)\n", - paddress (gdbarch, - record_list->u.mem.addr), - (unsigned long) sizeof (addr), - (unsigned long) sizeof (len), - record_list->u.mem.len); + paddress (gdbarch, + record_list->u.mem.addr), + (unsigned long) sizeof (addr), + (unsigned long) sizeof (len), + record_list->u.mem.len); =20 /* Write memlen. */ len =3D netorder32 (record_list->u.mem.len); @@ -2356,11 +2357,11 @@ cmd_record_save (char *args, int from_tt break; =20 case record_end: - if (record_debug) - printf_filtered ("\ + if (record_debug) + fprintf_unfiltered (gdb_stdlog, "\ Writing record_end (1 + %lu + %lu bytes)\n",=20 - (unsigned long) sizeof (signal), - (unsigned long) sizeof (count)); + (unsigned long) sizeof (signal), + (unsigned long) sizeof (count)); /* Write signal value. */ signal =3D netorder32 (record_list->u.end.sigval); bfdcore_write (obfd, osec, &signal,