From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8934 invoked by alias); 29 Oct 2009 17:28:04 -0000 Received: (qmail 8926 invoked by uid 22791); 29 Oct 2009 17:28:04 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 29 Oct 2009 17:28:00 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 6603710ED4; Thu, 29 Oct 2009 17:27:59 +0000 (GMT) Received: from caradoc.them.org (209.195.188.212.nauticom.net [209.195.188.212]) by nan.false.org (Postfix) with ESMTP id 4C94210ED3; Thu, 29 Oct 2009 17:27:59 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1N3Yn0-0004Vd-Q0; Thu, 29 Oct 2009 13:27:58 -0400 Date: Thu, 29 Oct 2009 17:28:00 -0000 From: Daniel Jacobowitz To: Joel Brobecker Cc: gdb-patches@sourceware.org Subject: Re: [RFC] design question re: watchpoint target methods Message-ID: <20091029172758.GB17276@caradoc.them.org> Mail-Followup-To: Joel Brobecker , gdb-patches@sourceware.org References: <20091029145817.GO24340@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20091029145817.GO24340@adacore.com> User-Agent: Mutt/1.5.20 (2009-06-14) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-10/txt/msg00689.txt.bz2 On Thu, Oct 29, 2009 at 07:58:17AM -0700, Joel Brobecker wrote: > And to replace them by by a new operation: > > enum stopped_by_watchpoint (*to_thread_stopped_by_watchpoint) > (ptid_t ptid, CORE_ADDR *data_address_p); > > Actually, I think that all target_ops operations should take a struct > target_ops parameter, even if not needed, at least for consistency, but > also to facilitate transitions if this parameter ever becomes needed > later on. This sounds sensible to me. -- Daniel Jacobowitz CodeSourcery