From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFC] design question re: watchpoint target methods
Date: Thu, 29 Oct 2009 15:46:00 -0000 [thread overview]
Message-ID: <20091029154414.GA6824@host0.dyn.jankratochvil.net> (raw)
In-Reply-To: <20091029145817.GO24340@adacore.com>
On Thu, 29 Oct 2009 15:58:17 +0100, Joel Brobecker wrote:
> enum stopped_by_watchpoint (*to_thread_stopped_by_watchpoint)
> (ptid_t ptid, CORE_ADDR *data_address_p);
>
> Actually, I think that all target_ops operations should take a struct
> target_ops parameter, even if not needed, at least for consistency, but
> also to facilitate transitions if this parameter ever becomes needed
> later on.
OK, I had some wrong assumptions, I see it fits more the targets abstractions,
I agree with adding it there.
Thanks,
Jan
next prev parent reply other threads:[~2009-10-29 15:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-29 14:58 Joel Brobecker
2009-10-29 15:46 ` Jan Kratochvil [this message]
2009-10-29 17:25 ` David Daney
2009-10-29 17:28 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091029154414.GA6824@host0.dyn.jankratochvil.net \
--to=jan.kratochvil@redhat.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox