From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8649 invoked by alias); 20 Oct 2009 11:20:56 -0000 Received: (qmail 8640 invoked by uid 22791); 20 Oct 2009 11:20:56 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 20 Oct 2009 11:20:51 +0000 Received: (qmail 10837 invoked from network); 20 Oct 2009 11:20:49 -0000 Received: from unknown (HELO orlando) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 20 Oct 2009 11:20:49 -0000 From: Pedro Alves To: Hui Zhu Subject: Re: [commit] multi-executable support Date: Tue, 20 Oct 2009 11:20:00 -0000 User-Agent: KMail/1.9.10 Cc: gdb-patches@sourceware.org References: <200910191106.28905.pedro@codesourcery.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200910201220.54860.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-10/txt/msg00465.txt.bz2 On Tuesday 20 October 2009 07:13:58, Hui Zhu wrote: > darwin-nat.c > if (breakpoint_inserted_here_p (pc)) Thanks. "grep breakpoint_inserted_here_p *nat*" doesn't find any other missing adjustment in native target files. I've no easy way to test this, but the needed change is very simple. Plus, this function is a copy of linux-nat.c:cancel_breakpoint, where I did the exact same change. I'm applying this. 2009-10-20 Pedro Alves * darwin-nat.c (cancel_breakpoint): Pass the regcache's address space to breakpoint_inserted_here_p. --- gdb/darwin-nat.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: src/gdb/darwin-nat.c =================================================================== --- src.orig/gdb/darwin-nat.c 2009-10-20 12:15:12.000000000 +0100 +++ src/gdb/darwin-nat.c 2009-10-20 12:16:03.000000000 +0100 @@ -995,7 +995,7 @@ cancel_breakpoint (ptid_t ptid) CORE_ADDR pc; pc = regcache_read_pc (regcache) - gdbarch_decr_pc_after_break (gdbarch); - if (breakpoint_inserted_here_p (pc)) + if (breakpoint_inserted_here_p (get_regcache_aspace (regcache), pc)) { inferior_debug (4, "cancel_breakpoint for thread %x\n", ptid_get_tid (ptid)); -- Pedro Alves