From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12789 invoked by alias); 19 Oct 2009 20:03:30 -0000 Received: (qmail 12678 invoked by uid 22791); 19 Oct 2009 20:03:29 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 19 Oct 2009 20:03:26 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id ACC962BACA4; Mon, 19 Oct 2009 16:03:24 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id xDuSId+RJkWo; Mon, 19 Oct 2009 16:03:24 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 53AC42BAC62; Mon, 19 Oct 2009 16:03:24 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 245DAF5921; Mon, 19 Oct 2009 22:03:22 +0200 (CEST) Date: Mon, 19 Oct 2009 20:03:00 -0000 From: Joel Brobecker To: Michael Snyder Cc: "gdb-patches@sourceware.org" , Hui Zhu Subject: Re: [RFA] New testes for process record save/restore commands Message-ID: <20091019200322.GD5282@adacore.com> References: <4ADCC1CE.1090304@vmware.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4ADCC1CE.1090304@vmware.com> User-Agent: Mutt/1.5.18 (2008-05-17) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-10/txt/msg00451.txt.bz2 > 2009-10-19 Michael Snyder > > * gdb.reverse/break-precsave.exp: New test. > * gdb.reverse/consecutive-precsave.exp: Ditto. > * gdb.reverse/finish-precsave.exp: Ditto. > * gdb.reverse/i386-precsave.exp: Ditto. > * gdb.reverse/machinestate-precsave.exp: Ditto. > * gdb.reverse/sigall-precsave.exp: Ditto. > * gdb.reverse/solilb-precsave.exp: Ditto. > * gdb.reverse/step-precsave.exp: Ditto. > * gdb.reverse/until-precsave.exp: Ditto. > * gdb.reverse/watch-precsave.exp: Ditto. I only quickly scanned the files, since they are essentially duplicates of already-existing testcases. I didn't expect to find anything, but I actually did notice a couple of things: - Use of send_gdb/gdb_expect which should be replaced by gdb_test_multiple (too bad we didn't catch those in the current ones when the testcases were checked in) - unnecessary "return 0" at the end of the script. I think we shouldn't put anything unnecessary in these files, as we tend to forget why we put them, and the next developer who, like me, writes testcase by copy/paste, will repeat the pattern because he's afraid of breaking something otherwise. -- Joel