From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20436 invoked by alias); 19 Oct 2009 19:56:51 -0000 Received: (qmail 20428 invoked by uid 22791); 19 Oct 2009 19:56:50 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 19 Oct 2009 19:56:45 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 7A253105BB; Mon, 19 Oct 2009 19:56:44 +0000 (GMT) Received: from caradoc.them.org (209.195.188.212.nauticom.net [209.195.188.212]) by nan.false.org (Postfix) with ESMTP id 6099110576; Mon, 19 Oct 2009 19:56:44 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1MzyLU-0006wO-0Z; Mon, 19 Oct 2009 15:56:44 -0400 Date: Mon, 19 Oct 2009 19:56:00 -0000 From: Daniel Jacobowitz To: Joel Brobecker Cc: Paul Pluzhnikov , tromey@redhat.com, gdb-patches@sourceware.org Subject: Re: [RFC][patch] Allow to disassemble line. Message-ID: <20091019195643.GB25499@caradoc.them.org> Mail-Followup-To: Joel Brobecker , Paul Pluzhnikov , tromey@redhat.com, gdb-patches@sourceware.org References: <20091002004954.8966C76B2B@ppluzhnikov.mtv.corp.google.com> <8ac60eac0910080916i5a2eb49an5f21f3b5c7fb96ef@mail.gmail.com> <20091008162350.GA8625@caradoc.them.org> <8ac60eac0910080952p46f15693x6ed339473db0139d@mail.gmail.com> <8ac60eac0910161607k55fee22cs379c5b7635d7b6a@mail.gmail.com> <8ac60eac0910191109v62794c33g6712090912b5c11f@mail.gmail.com> <20091019184853.GA18564@caradoc.them.org> <20091019194030.GB5282@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20091019194030.GB5282@adacore.com> User-Agent: Mutt/1.5.20 (2009-06-14) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-10/txt/msg00449.txt.bz2 On Mon, Oct 19, 2009 at 09:40:30PM +0200, Joel Brobecker wrote: > Wouldn't it be a problem with targets using MI? Or IDEs that run > GDB through a pipe (thinking of Windows in this case)? I hope they don't use the CLI disassemble command; there's been an MI equivalent for ages. But yes, anything we change could break anything... > > (gdb) x/2i main > > Dump of assembler code for function main: > > 0x44cce0 (+0): sub $0x28,%rsp > > 0x44cce4 (+4): movq $0x0,(%rsp) > > This one is a little less obviously nice. I have little user-define > functions such as "ssi" which does "stepi; x /i $pc". Having the > output fit in a couple of lines would really add clutter in this case > (IMO). Good point; I use display/i $pc all the time. And I do find the offsets useful, just not the function name. I suppose it could be an option... -- Daniel Jacobowitz CodeSourcery