From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28800 invoked by alias); 17 Oct 2009 05:06:10 -0000 Received: (qmail 28656 invoked by uid 22791); 17 Oct 2009 05:06:09 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from e24smtp05.br.ibm.com (HELO e24smtp05.br.ibm.com) (32.104.18.26) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 17 Oct 2009 05:06:04 +0000 Received: from mailhub3.br.ibm.com (mailhub3.br.ibm.com [9.18.232.110]) by e24smtp05.br.ibm.com (8.14.3/8.13.1) with ESMTP id n9H50u4l028990 for ; Sat, 17 Oct 2009 02:00:56 -0300 Received: from d24av02.br.ibm.com (d24av02.br.ibm.com [9.18.232.47]) by mailhub3.br.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id n9H56leu2142268 for ; Sat, 17 Oct 2009 02:06:47 -0300 Received: from d24av02.br.ibm.com (loopback [127.0.0.1]) by d24av02.br.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n9H5611u012687 for ; Sat, 17 Oct 2009 02:06:01 -0300 Received: from miki.localnet ([9.8.9.71]) by d24av02.br.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id n9H560P2012676 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sat, 17 Oct 2009 02:06:00 -0300 From: =?iso-8859-1?q?S=E9rgio_Durigan_J=FAnior?= To: gdb-patches@sourceware.org Subject: Re: [PATCH] Fix building gdb-7.0 on x86_64-*-freebsd Date: Sat, 17 Oct 2009 05:06:00 -0000 User-Agent: KMail/1.12.2 (Linux/2.6.30.4; KDE/4.3.2; i686; ; ) Cc: Steve Kargl , Joel Brobecker References: <20091012215518.GA45050@troutmask.apl.washington.edu> <20091016232238.GV5288@adacore.com> <20091017001631.GA60006@troutmask.apl.washington.edu> In-Reply-To: <20091017001631.GA60006@troutmask.apl.washington.edu> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Message-Id: <200910170205.58841.sergiodj@linux.vnet.ibm.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-10/txt/msg00384.txt.bz2 On Friday 16 October 2009, Steve Kargl wrote: > > > +#if (__FreeBSD_version < 800075) > > > regcache_raw_supply (regcache, AMD64_DS_REGNUM, &pcb->pcb_ds); > > > regcache_raw_supply (regcache, AMD64_ES_REGNUM, &pcb->pcb_es); > > > regcache_raw_supply (regcache, AMD64_FS_REGNUM, &pcb->pcb_fs); > > > regcache_raw_supply (regcache, AMD64_GS_REGNUM, &pcb->pcb_gs); > > > +#endif >=20 > The above number 800075 means that any version of FreeBSD > with __FreeBSD_version less than 800075 will have a struct pcb > with the pcb_{fged} members. Any version with __FreeBSD_version > greater than or equal to 800075 will have these structure members > removed. The '8' in 800075 signifies the FreeBSD 8-branch. > The '75' signifies that 75 changes have occurred on the FreeBSD > 8-branch that might need special handling. The removal of the > struct members occurred on 2009-04-01 while the version number > was bumped to 800075 on 2009-04-06. It's the closest version > number that will work in the '#if (...)' that will allow the > gdb-7.x branch to build on all versions of FreeBSD on the amd64 > architecture including the 8.0-Release Candidates (ie., the > beta releases). Hi Steve, Thank you for this patch. I believe you could add a comment explaining wha= t=20 this number means (just like you did above). What do you think? Just my two cents, as usual :-). Regards, --=20 S=E9rgio Durigan J=FAnior Linux on Power Toolchain - Software Engineer Linux Technology Center - LTC IBM Brazil