From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13058 invoked by alias); 14 Oct 2009 22:29:11 -0000 Received: (qmail 13049 invoked by uid 22791); 14 Oct 2009 22:29:10 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 14 Oct 2009 22:29:04 +0000 Received: (qmail 23647 invoked from network); 14 Oct 2009 22:29:02 -0000 Received: from unknown (HELO orlando) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 14 Oct 2009 22:29:02 -0000 From: Pedro Alves To: Paul Pluzhnikov Subject: Re: [patch] Fix for internal-error: linux_nat_post_attach_wait: Assertion `pid == new_pid && WIFSTOPPED (status)' failed. Date: Wed, 14 Oct 2009 22:29:00 -0000 User-Agent: KMail/1.9.10 Cc: gdb-patches@sourceware.org References: <20091013184120.30A5776761@ppluzhnikov.mtv.corp.google.com> <200910142216.46073.pedro@codesourcery.com> <8ac60eac0910141428t428f0accqa16008c53cac5c16@mail.gmail.com> In-Reply-To: <8ac60eac0910141428t428f0accqa16008c53cac5c16@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200910142329.06920.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-10/txt/msg00323.txt.bz2 On Wednesday 14 October 2009 22:28:26, Paul Pluzhnikov wrote: > I am having a bit of trouble coming up with the right verbiage. > How about: > > error (_("Unable to attach: program exited normally.")); > > Alternatives: > > error (_("While attaching program exited normally.")); > error (_("During attach program exited normally.")); > > don't sound grammatically correct to me (and a comma is probably > missing from at least one of the above). I've no preference really. Any of those is fine with me. If someone else wants to suggest something, I'm sure they'll speak up now. :-) Something else I noticed: > + int signo = WTERMSIG (status); Should be: enum target_signal signo = target_signal_from_host (WTERMSIG (status)); > + > + target_terminal_ours (); > + target_mourn_inferior (); > + error (_("During startup program terminated with signal %s, %s."), > + target_signal_to_name (signo), > + target_signal_to_string (signo)); ^^^^^^^^^^^^^^^^^^^^^^^ because these functions take a target independent gdb signal (TARGET_SIGNAL_...). Yes, it's confusing. -- Pedro Alves