Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: Michael Eager <eager@eagercon.com>
Cc: Joel Brobecker <brobecker@adacore.com>,
		"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
		Eli Zaretskii <eliz@gnu.org>
Subject: Re: [PATCH] Support for Xilinx MicroBlaze
Date: Wed, 14 Oct 2009 17:56:00 -0000	[thread overview]
Message-ID: <20091014175615.GA27572@caradoc.them.org> (raw)
In-Reply-To: <4AD60F09.6020607@eagercon.com>

On Wed, Oct 14, 2009 at 10:48:57AM -0700, Michael Eager wrote:
> >>+  struct regcache *regcache = get_current_regcache ();
> >
> >This one raised a red flag, as we try to avoid depending on global
> >variables.  But I'm not sure what the kosher way of getting the regcache
> >would be. I thought there would be method to get the regcache from
> >a frame, but apparently not.  Perhaps the right way is to use
> >get_thread_arch_regcache (inferior_ptid, gdbarch), but I'm not sure.
> >I'll ask Ulrich, who knows this area a lot better.
> 
> I wasn't able to find a better way to get the regcache either.  Perhaps
> it's known farther up the call tree, but it isn't passed to the
> software single step routine.

Why do you need the regcache, rather than getting registers from the
frame?

-- 
Daniel Jacobowitz
CodeSourcery


  reply	other threads:[~2009-10-14 17:56 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-06  1:35 Michael Eager
2009-10-06  7:14 ` Eli Zaretskii
2009-10-14  1:47 ` Joel Brobecker
2009-10-14 17:49   ` Michael Eager
2009-10-14 17:56     ` Daniel Jacobowitz [this message]
2009-10-14 18:01       ` Michael Eager
2009-10-15 16:32 Michael Eager
2009-10-15 16:44 ` Tom Tromey
2009-10-15 16:47   ` Joel Brobecker
2009-10-15 18:00     ` Tom Tromey
2009-10-15 18:04       ` Tom Tromey
2009-10-15 18:31         ` Joel Brobecker
2009-10-16 12:53         ` Daniel Jacobowitz
2009-10-16 16:14           ` Michael Eager
2009-10-15 17:12   ` Michael Eager
2009-10-15 17:18     ` Joel Brobecker
2009-10-15 18:06       ` Michael Eager
2009-10-15 16:46 ` Joel Brobecker
2009-10-15 17:14   ` Michael Eager
2009-10-15 19:31   ` Michael Eager

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091014175615.GA27572@caradoc.them.org \
    --to=drow@false.org \
    --cc=brobecker@adacore.com \
    --cc=eager@eagercon.com \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox