Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org,  tromey@redhat.com
Cc: Joel Brobecker <brobecker@adacore.com>
Subject: Re: [v8] multi-executable support
Date: Wed, 14 Oct 2009 16:48:00 -0000	[thread overview]
Message-ID: <200910141748.28719.pedro@codesourcery.com> (raw)
In-Reply-To: <m34oq2djuy.fsf@fleche.redhat.com>

On Wednesday 14 October 2009 17:24:21, Tom Tromey wrote:
> >>>>> "Pedro" == Pedro Alves <pedro@codesourcery.com> writes:
> 
> Pedro> Any suggestions?  Assuming languages have only singular and one
> Pedro> plural form [if (n == 1) else ...] is frowned uppon as well.
> Pedro>  "1 inferior(s) added." ?
> Pedro>  "Added 1 inferior(s)." ?
> Pedro>  Just drop the sentence?
> 
> gettext has support for this.  See (info "(gettext)Plural Forms"),
> specifically the "ngettext" function.
> 
> In this case I think you would write:
> 
>   printf_filtered (ngettext ("%d inferior added.\n", "%d inferiors added.\n",
> 			     copies),
> 		   copies);
> 

Thanks, had seen that.  I had noticed that gdb_locale.h doesn't wrap
ngettext, and GDB doesn't use it anywhere, so I just perhaps wrongly
assumed that ngettext would be missing on some non-GNU gettext
implementations.

In any case, I'm not concerned that users will miss the
sentence, so I'll just drop it.

> Glancing at the patch it seems to be missing some _() calls in this
> area.

Eh, indeed.  I'll go through the patch to see if more are
missing.  Thanks.

-- 
Pedro Alves


  reply	other threads:[~2009-10-14 16:48 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-05 15:59 [v6] " Pedro Alves
2009-10-05 21:57 ` Eli Zaretskii
2009-10-06 12:14   ` Pedro Alves
2009-10-06 14:29     ` Eli Zaretskii
2009-10-12  1:26     ` [v7] " Pedro Alves
2009-10-12 19:09       ` Eli Zaretskii
2009-10-13 13:40         ` [v8] " Pedro Alves
2009-10-14  3:03           ` Joel Brobecker
2009-10-14 15:16             ` Pedro Alves
2009-10-14 15:28               ` Joel Brobecker
2009-10-14 16:25               ` Tom Tromey
2009-10-14 16:48                 ` Pedro Alves [this message]
2009-10-14 17:41                   ` Tom Tromey
2009-10-06  5:13 ` [v6] " Sérgio Durigan Júnior
2009-10-06 13:55   ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200910141748.28719.pedro@codesourcery.com \
    --to=pedro@codesourcery.com \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox