From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31753 invoked by alias); 14 Oct 2009 03:03:29 -0000 Received: (qmail 31577 invoked by uid 22791); 14 Oct 2009 03:03:27 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 14 Oct 2009 03:03:22 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 2E2B52BAC18; Tue, 13 Oct 2009 23:03:21 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id VS2GrapIzDuo; Tue, 13 Oct 2009 23:03:21 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id D16282BABAB; Tue, 13 Oct 2009 23:03:20 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 402FAF58A0; Tue, 13 Oct 2009 20:03:10 -0700 (PDT) Date: Wed, 14 Oct 2009 03:03:00 -0000 From: Joel Brobecker To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [v8] multi-executable support Message-ID: <20091014030310.GR5272@adacore.com> References: <200910051659.20885.pedro@codesourcery.com> <200910120226.08575.pedro@codesourcery.com> <83r5t8ig10.fsf@gnu.org> <200910131440.48021.pedro@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200910131440.48021.pedro@codesourcery.com> User-Agent: Mutt/1.5.18 (2008-05-17) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-10/txt/msg00298.txt.bz2 Pedro, I finally had some time to read through the lengthy threads for this. I'll confess that I didn't look at the code much because I'm starved for time and I trust you implicitly. I just looked at the discussions and the resulting UI that you now propose. I like the UI, and the concepts behind it. I did a careful reading of the introductory comment in progspace.h and it's great that you took the time to provide such a detailed introduction. I'm planning on extending it to discuss the VxWorks case :-). Just a few nits: There is at least one location where I noticed some "#if 0"'ed code, and I just told one of the contributors that we'd like to avoid this sort of thing. Can it be removed, or should we really be keeping that piece of commented out code. We usually use FIXMEs instead. In the documentation: +(@value{GDBP}) clone-inferior +Added inferior 2. +1 inferiors added. This is really nit-picking, but when adding 1 inferior, should we have a special message that does not say "inferiors" (plural). I usually don't care much about this sort of detail, but for some reason, it seems to matter to me in this case. I am very impressed with the level of functionality that this patch is bringing to GDB, and I look forward to seeing it part of GDB. Just a personal request: If you commit the patch before Saturday, could you just give me a heads up. I just want to make sure that I can get a checkout of the sources before you apply your patch. I think that the patch is going to break our VxWorks port, and I think that fixing it will require a bit of thoughts and time. So if I can do a resync of the AdaCore sources up to before your patch, that'll give me a little more time. Cheers, -- Joel