From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7520 invoked by alias); 8 Oct 2009 16:20:55 -0000 Received: (qmail 7509 invoked by uid 22791); 8 Oct 2009 16:20:54 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 08 Oct 2009 16:20:49 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 83A132BAC03; Thu, 8 Oct 2009 12:20:47 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id k4ZdOt+nlvb3; Thu, 8 Oct 2009 12:20:47 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 285F82BAB5F; Thu, 8 Oct 2009 12:20:47 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 2D78FF589F; Thu, 8 Oct 2009 09:20:40 -0700 (PDT) Date: Thu, 08 Oct 2009 16:20:00 -0000 From: Joel Brobecker To: Paul Pluzhnikov Cc: gdb-patches ml , Holger Freyther Subject: Re: [patch] Fix for excessive stack use (gdb/10457) Message-ID: <20091008162040.GB11440@adacore.com> References: <8ac60eac0910072229s432c6480k5788878ca414b255@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8ac60eac0910072229s432c6480k5788878ca414b255@mail.gmail.com> User-Agent: Mutt/1.5.18 (2008-05-17) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-10/txt/msg00169.txt.bz2 > 2009-10-07 Paul Pluzhnikov > > * elfread.c (elf_symtab_read): Don't use alloca in a loop. alloca was very convenient because it allows us to not worry about memory leaks that could happen if record_minimal_symbol throws an error, for instance. Thanks to Jan's excellent eyes, we know that record_minimal_symbol eventually results in a call to XCALLOC, which can possibly cause an internal_error(). It's very unlikely to happen. So I wouldn't have complained if you had used a cleanup to make sure that the memory is always released. But in this case, I don't see record_minimal_symbol ever needing to thrown an exception on its own, and I don't see that such a small leak can make a difference if we run out of memory. The patch is approved. -- Joel