From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23838 invoked by alias); 7 Oct 2009 19:40:46 -0000 Received: (qmail 23829 invoked by uid 22791); 7 Oct 2009 19:40:45 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 07 Oct 2009 19:40:39 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n97JduZs007851; Wed, 7 Oct 2009 15:39:57 -0400 Received: from host0.dyn.jankratochvil.net (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id n97JdrGH021424 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 7 Oct 2009 15:39:56 -0400 Received: from host0.dyn.jankratochvil.net (localhost [127.0.0.1]) by host0.dyn.jankratochvil.net (8.14.3/8.14.3) with ESMTP id n97JdrS6005526; Wed, 7 Oct 2009 21:39:53 +0200 Received: (from jkratoch@localhost) by host0.dyn.jankratochvil.net (8.14.3/8.14.3/Submit) id n97Jdq1S005525; Wed, 7 Oct 2009 21:39:52 +0200 Date: Wed, 07 Oct 2009 19:40:00 -0000 From: Jan Kratochvil To: Joel Brobecker Cc: gdb-patches@sourceware.org Subject: Re: [patch 3/4] Fix hw watchpoints: remove dead code [update] Message-ID: <20091007193952.GA5032@host0.dyn.jankratochvil.net> References: <20090817194624.GD10694@host0.dyn.jankratochvil.net> <20091003171059.GC26203@host0.dyn.jankratochvil.net> <20091007185110.GS5689@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20091007185110.GS5689@adacore.com> User-Agent: Mutt/1.5.20 (2009-08-17) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-10/txt/msg00158.txt.bz2 On Wed, 07 Oct 2009 20:51:10 +0200, Joel Brobecker wrote: > > 2009-08-17 Jan Kratochvil > > > > * i386-nat.c (i386_stopped_by_hwbp): Remove. > > Thanks for taking care of that. This part has been checked-in. Thanks, Jan http://sourceware.org/ml/gdb-cvs/2009-10/msg00053.html --- src/gdb/ChangeLog 2009/10/07 18:27:22 1.10940 +++ src/gdb/ChangeLog 2009/10/07 19:35:05 1.10941 @@ -1,4 +1,8 @@ -2009-10-09 Joel Brobecker +2009-10-07 Jan Kratochvil + + * i386-nat.c (i386_stopped_by_hwbp): Remove. + +2009-10-07 Joel Brobecker * NEWS: Update following the GDB 7.0 release. --- src/gdb/i386-nat.c 2009/09/26 12:08:30 1.25 +++ src/gdb/i386-nat.c 2009/10/07 19:35:06 1.26 @@ -581,27 +581,6 @@ return i386_stopped_data_address (¤t_target, &addr); } -/* Return non-zero if the inferior has some break/watchpoint that - triggered. */ - -static int -i386_stopped_by_hwbp (void) -{ - int i; - - dr_status_mirror = i386_dr_low.get_status (); - if (maint_show_dr) - i386_show_dr ("stopped_by_hwbp", 0, 0, hw_execute); - - ALL_DEBUG_REGISTERS(i) - { - if (I386_DR_WATCH_HIT (i)) - return 1; - } - - return 0; -} - /* Insert a hardware-assisted breakpoint at BP_TGT->placed_address. Return 0 on success, EBUSY on failure. */ static int